chore: Extract (connor, crdt, core) errors to errors.go #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These errors are already defra errors and already have a stacktrace attached
AndrewSisley
added
area/errors
Codecov Report
@@ Coverage Diff @@
## develop #968 +/- ##
===========================================
- Coverage 59.86% 59.83% -0.03%
===========================================
Files 157 160 +3
Lines 17716 17724 +8
===========================================
Hits 10605 10605
- Misses 6157 6165 +8
Partials 954 954
|
AndrewSisley
changed the title
AndrewSisley
changed the title
shahzadlone
approved these changes
Dec 15, 2022
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…k#968) * Extract connor errors to errors.go * Extract crdt errors to errors.go * Move crdt error to crdt package * Remove ineffective WithStack call These errors are already defra errors and already have a stacktrace attached * Extract core errors to errors.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Part of #257
Description
Extracts inline (connor, crdt, core) errors to errors.go. A few of the connor errors were incorrect and have been changed.