chore: Extract (events, merkle) errors to errors.go #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
area/errors
AndrewSisley
commented
Dec 16, 2022
| @@ -104,7 +102,7 @@ func (mc *MerkleClock) AddDAGNode( | |||
| // write the delta and heads to a new block | |||
| nd, err := mc.putBlock(ctx, heads, height, delta) | |||
| if err != nil { | |||
| return nil, errors.Wrap("could not add block ", err) | |||
| return nil, err | |||
There was a problem hiding this comment.
I dropped this wrap and the one at the one at the end as they are wrapping previously well defined errors local to this package and dont really seem to add any value
AndrewSisley
force-pushed
the
sisley/chore/I257-extract-errors-4
branch
from
c05babb
to
3f3120e
Compare
Codecov Report
@@ Coverage Diff @@
## develop #973 +/- ##
===========================================
- Coverage 57.82% 57.72% -0.11%
===========================================
Files 169 170 +1
Lines 19420 19440 +20
===========================================
- Hits 11229 11221 -8
- Misses 7202 7226 +24
- Partials 989 993 +4
|
shahzadlone
approved these changes
Dec 16, 2022
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
* Extract events errors to errors.go * Extract clock errors to errors.go * Extract crdt errors to errors.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Part of #257
Description
Extracts (events, merkle) errors to errors.go. Smaller PR as the next packages are net and node which are a bit larger RE errors and I dont want that to get too big.