Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Bump all gh-action versions to support node16 #990

Merged
merged 1 commit into from
Dec 23, 2022
Merged

ci: Bump all gh-action versions to support node16 #990

merged 1 commit into from
Dec 23, 2022

Conversation

shahzadlone
Copy link
Member

Relevant issue(s)

Resolves #979

Description

This PR ensures all old versions of GitHub actions that will soon be deprecated are bumped up.

Note: When I made the issue I thought there might be many actions that would be need to be updated after #978. Turns out only the code coverage action needed an update to fix the warnings.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

CI

Specify the platform(s) on which this was tested:

  • WSL2 Manjaro

@shahzadlone shahzadlone added ci/build This is issue is about the build or CI system, and the administration of it. code quality Related to improving code quality action/no-benchmark Skips the action that runs the benchmark. labels Dec 23, 2022
@shahzadlone shahzadlone added this to the DefraDB v0.4 milestone Dec 23, 2022
@shahzadlone shahzadlone requested a review from a team December 23, 2022 17:39
@shahzadlone shahzadlone self-assigned this Dec 23, 2022
fredcarle
fredcarle approved these changes Dec 23, 2022
View reviewed changes
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shahzadlone shahzadlone merged commit d06beb1 into develop Dec 23, 2022
@shahzadlone shahzadlone deleted the lone/ci/update-github-actions-to-node16 branch December 23, 2022 19:11
shahzadlone added a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@shahzadlone
ci: Bump all gh-action versions to support node16 (sourcenetwork#990)
1b0a9ed 
- Resolves sourcenetwork#979 

- This PR ensures all old versions of GitHub actions that will soon be deprecated are bumped up.
This was referenced Jun 25, 2024
Closed
Merged
shahzadlone added a commit that referenced this pull request Jun 27, 2024
@shahzadlone
ci(i): Bump all gh-action versions to support node20 (#2780)
343ec38 
## Relevant issue(s)
Resolves #2778

## Description
- Similar to #990
- Update all actions to `node20` versions
- There was a bug the way we were using artifacts previously such that
it would overwrite some generated code coverage reports due to artifact
name clashing, this was caught as the behavior of "artifact name
clashing" now causes error instead of "merging" them. The fix is in the
last commit, which will now ensure "more" accurate coverage as the
missing 3 reports are also included.

### Go Releaser
- This should be done outside this PR, made an issue here:
#2781

## How has this been tested?
- `act` tool
- ci

Specify the platform(s) on which this was tested:
- WSL2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredcarle fredcarle fredcarle approved these changes

Assignees

@shahzadlone shahzadlone

Labels
action/no-benchmark Skips the action that runs the benchmark. ci/build This is issue is about the build or CI system, and the administration of it. code quality Related to improving code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update all actions to Node16 instead of Node12
2 participants
@shahzadlone @fredcarle