Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add method to MinHash class to update abundances for a specific hash #1018

Closed
ctb opened this issue Jun 8, 2020 · 1 comment · Fixed by #1046
Closed

add method to MinHash class to update abundances for a specific hash #1018

ctb opened this issue Jun 8, 2020 · 1 comment · Fixed by #1046

Comments

@ctb
Copy link
Contributor

ctb commented Jun 8, 2020

Turns out there's no simple way to just set the abundance of a specific hash in a MinHash(..., track_abundance=True)!

set_abundances(...) takes a dictionary of { hash: abund } and clears the MinHash before setting it. An easy patch might be to adjust set_abundances to have an optional "no_clear" argument.
@ctb
Copy link
Contributor Author

ctb commented Jun 20, 2020

dup of #893

@erikyoung85 erikyoung85 mentioned this issue Jun 25, 2020
Merged
5 tasks
@ctb ctb closed this as completed in #1046 Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MRG] Add clear option to set_abundances(...) method sourmash-bio/sourmash
1 participant
@ctb