Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

separate out load_signatures code to distinguish loading-from-file and parsing-from-string #1060

Open
ctb opened this issue Jun 28, 2020 · 3 comments
Open

separate out load_signatures code to distinguish loading-from-file and parsing-from-string #1060

ctb opened this issue Jun 28, 2020 · 3 comments
Labels
5.0 issues to address for a 5.0 release
Milestone
5.0

Comments

@ctb
Copy link
Contributor

ctb commented Jun 28, 2020 •
edited
Loading

per #875 (comment)

this would be an API change to a frequently used function, so gotta be careful and do this for a major version change.
@ctb ctb added the 4.0 issues to address for a 4.0 release label Jun 28, 2020
@ctb
Copy link
Contributor Author

ctb commented Jan 10, 2021

punt to 5.0, I think.

@ctb ctb added 5.0 issues to address for a 5.0 release and removed 4.0 issues to address for a 4.0 release labels Jan 10, 2021
@ctb ctb mentioned this issue Apr 3, 2021
Merged
5 tasks
@ctb ctb mentioned this issue May 4, 2022
Open
@luizirber luizirber added this to the 5.0 milestone Dec 1, 2023
@ctb ctb mentioned this issue May 13, 2024
Merged
2 tasks
@ctb
Copy link
Contributor Author

ctb commented May 14, 2024

pretty sure this bug #2945 is caused by the checks put in place to support loading from string.

ref:

@ctb ctb changed the title separate out load_signatures code to distinguish loading-from-file and parsing-from-buffer separate out load_signatures code to distinguish loading-from-file and parsing-from-string May 14, 2024
@ctb
Copy link
Contributor Author

ctb commented May 14, 2024

this would be an API change to a frequently used function, so gotta be careful and do this for a major version change.

#3161 completes the task of making this a not-public function (deprecated for v5.0, removed from most internal use, and renamed to load_signatures_from_json). So we'll be in good shape for changing the behavior for the future.

ctb added a commit that referenced this issue Jun 4, 2024
@ctb @pre-commit-ci
MRG: upgrade sig overlap and sig subtract to load more than JSON …
2542c69 
…signatures (#3153)

Fix `sig overlap` and `sig subtract` to take more than just JSON
signatures.

Also, adds a function `sourmash_args.load_one_signature` that I think
should (eventually) replace the now-deprecated
`sourmash.signature.load_one_signature`. This will be the topic of a new
PR - for now, I think it's a nice quick fix!

Fixes #3136

Related issues:
* #1062 - will do another
PR to close this issue
* #1877
* #1312
* #1060

TODO:
- [x] test uncovered code
- [x] do a bit more of a search and digest of related issues to see if
there's other low hanging fruit

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
5.0 issues to address for a 5.0 release
Projects
None yet
Milestone
5.0
Development

No branches or pull requests
2 participants
@luizirber @ctb