Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ksize selectors accidentally removed from (many) sourmash sig commands #1104

Closed
ctb opened this issue Jul 16, 2020 · 0 comments · Fixed by #1105
Closed

ksize selectors accidentally removed from (many) sourmash sig commands #1104

ctb opened this issue Jul 16, 2020 · 0 comments · Fixed by #1105

Comments

@ctb
Copy link
Contributor

ctb commented Jul 16, 2020

whoops, looks like my update in #1059 removed all of the -k selectors on the sourmash sig functions! For example, look at https://github.com/dib-lab/sourmash/pull/1059/files#diff-5fe82707329c767fb00caca4314b29b1L329. Alas.

so, two problems -

  • first, it appears we don't have tests for ksize selectors on this set of subcommands 😰
  • second, we need to add ksize selectors back in :)
@ctb ctb changed the title add ksize selectors back into (many) sourmash sig commands ksize selectors accidentally removed from (many) sourmash sig commands Jul 16, 2020
@ctb ctb mentioned this issue Jul 16, 2020
Merged
12 tasks
@ctb ctb closed this as completed in #1105 Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MRG] add ksize selectors back into sourmash sig functions sourmash-bio/sourmash
1 participant
@ctb