Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove quiet argument from sourmash.load_signatures #1141

Closed
ctb opened this issue Aug 3, 2020 · 0 comments · Fixed by #1279
Closed

remove quiet argument from sourmash.load_signatures #1141

ctb opened this issue Aug 3, 2020 · 0 comments · Fixed by #1279
Labels
4.0 issues to address for a 4.0 release

Comments

@ctb
Copy link
Contributor

ctb commented Aug 3, 2020

per #875 (comment), for 4.0 we should make load_signatures an internal function, and use sourmash_args.load_file_as_signatures and sourmash_args.load_database for the public API and the functions that are used directly by the command line. This means getting rid of error(...) calls and removing the quiet argument from sourmash.load_signatures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4.0 issues to address for a 4.0 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MRG] Deprecate sourmash.load_signatures as public API; refactor a bit. sourmash-bio/sourmash
1 participant
@ctb