Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should we prevent MinHash.count_common on num MinHashes? #1345

Closed
ctb opened this issue Feb 23, 2021 · 2 comments
Closed

should we prevent MinHash.count_common on num MinHashes? #1345

ctb opened this issue Feb 23, 2021 · 2 comments

Comments

@ctb
Copy link
Contributor

ctb commented Feb 23, 2021

count_common is only valid on scaled MinHashes, but no error or warning is raised on regular MinHashes.
@ctb ctb mentioned this issue Feb 28, 2021
Open
@ctb
Copy link
Contributor Author

ctb commented Mar 4, 2021

huh. apparently we use this a lot in our tests. go figure.

@ctb ctb mentioned this issue Mar 9, 2021
Merged
5 tasks
@ctb ctb closed this as completed Apr 23, 2021
@ctb
Copy link
Contributor Author

ctb commented Apr 23, 2021

superseded by #1345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ctb