Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should _load_databases indicate how many incompatible signatures were filtered out? #1426

Open
ctb opened this issue Mar 31, 2021 · 4 comments

Comments

@ctb
Copy link
Contributor

ctb commented Mar 31, 2021

After #1420, we run the risk of silently selecting away large numbers of incompatible signatures. Perhaps we should print this out in the _load_database code?

See for example test_search_traverse_incompatible as something that could say, "one signature was ignored."

@ctb
Copy link
Contributor Author

ctb commented Jun 26, 2021

#1637 is relevant - when do we complain about having empty databases to search? 😄

Also, UX principles for large collections #1350 - and enumerators (or progress bars?) #1082 - are much more straightforward with manifests.

@ctb
Copy link
Contributor Author

ctb commented Mar 26, 2022

See relevant comment on #1082 about how progress bars might not be possible or a good idea - #1082 (comment).

I'm wondering if the right answer is to track the total number of signatures in a collection (using e.g. manifests) and when doing a search of some kind, provide a generic indicator of what fraction of the collection is actually being searched? This should be straightforward.

@ctb
Copy link
Contributor Author

ctb commented Aug 3, 2022

I really like the idea that with manifests, we just output something like this:

loaded/found a total of X sketches
after sketch selection, Y sketches remaining

@ctb
Copy link
Contributor Author

ctb commented Aug 15, 2022

Updated in #2204 - sourmash_args.load_dbs_and_sigs now displays information like so:

loaded 384 total signatures from 65 locations.
after selecting signatures compatible with search, 128 remain.

This is only for the search, gather, and multigather subcommands presently, although prefetch displays similar output.

compare and the various sig subcommands remain to be tackled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant