Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--from-file vs pathlists - can we unify the way they work? #1665

Open
ctb opened this issue Jul 12, 2021 · 2 comments
Open

--from-file vs pathlists - can we unify the way they work? #1665

ctb opened this issue Jul 12, 2021 · 2 comments

Comments

@ctb
Copy link
Contributor

ctb commented Jul 12, 2021

We have a few different issues around adding --from-file to new commands, e.g. #1631.

As I was implementing #1657 for a different reason, though, I realized that pathlists and --from-file seem completely redundant. If true, it's kind of embarrassing that I didn't realize it before :).

However, even if they end up doing the same thing, there is a big difference in the user experience for these two. --from-file adds all the lines from the specified file onto the argument list, while pathlists are loaded as a single MultiIndex database containing all of the different indexes etc.

I'm wondering if there's a way to modify _load_database to provide the same UX; maybe we could modify the loading functions to yield multiple databases, rather than just one, and have pathlist load yield multiple dbs?

@ctb
Copy link
Contributor Author

ctb commented Mar 12, 2022

related: #1878 and #1877

@ctb
Copy link
Contributor Author

ctb commented Aug 3, 2022

consider removing pathlists altogether per #1414 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant