Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should we remove is_database from Index objects? #1894

Open
ctb opened this issue Mar 25, 2022 · 2 comments
Open

should we remove is_database from Index objects? #1894

ctb opened this issue Mar 25, 2022 · 2 comments
Labels
5.0 issues to address for a 5.0 release
Milestone
5.0

Comments

@ctb
Copy link
Contributor

ctb commented Mar 25, 2022

I don't think it serves a purpose any more; IIRC it was used to indicate that 'number of signatures' was not a useful designation Back When, but that is not really an internal distinction we use any more.
@ctb ctb mentioned this issue Mar 25, 2022
Open
@ctb
Copy link
Contributor Author

ctb commented Mar 25, 2022 •
edited
Loading

short answer is "yes, we should remove it." It no longer serves a useful distinction.

@ctb ctb added the 5.0 issues to address for a 5.0 release label Aug 14, 2022
@ctb ctb mentioned this issue Aug 14, 2022
Merged
4 tasks
@ctb
Copy link
Contributor Author

ctb commented Aug 14, 2022

#2204 removes the use of is_database in sourmash_args database loading.

However, we can't remove is_database completely until v5 because it changes the output of sourmash sig summarize.

@luizirber luizirber added this to the 5.0 milestone Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
5.0 issues to address for a 5.0 release
Projects
None yet
Milestone
5.0
Development

No branches or pull requests
2 participants
@luizirber @ctb