Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support outputting manifests or manifest-like files as direct -o output. #1902

Open
ctb opened this issue Mar 26, 2022 · 2 comments
Open

support outputting manifests or manifest-like files as direct -o output. #1902

ctb opened this issue Mar 26, 2022 · 2 comments

Comments

@ctb
Copy link
Contributor

ctb commented Mar 26, 2022

In #1493, we added sourmash_args.SaveSignaturesToLocation(...) to support a wide variety of output formats.

In #1891, we are adding the ability to read manifest files, as output by sourmash sig manifest.

Per the motivation in #1365, it would be nice to be able to output these manifest files as the result of searches etc. -o could maybe support that, under certain conditions - in particular, that all signatures were loaded from identifiable locations (so, not stdin; anything else?)

One concern is that these manifest files would not necessarily be that portable or relocatable, depending on whether they contained relative paths or abspaths - both are problems. So it could be a buyer-beware kind of situation to support @bluegenes -like people, that is, expert users.

@ctb
Copy link
Contributor Author

ctb commented Mar 26, 2022

in #1891, I'm adding sourmash sig check --output-manifest-matching which will output entries that match to a picklist in manifest format. Right now it's specific to this command, but we'll be using it for #1671 so if it proves out there we can revisit and implement more broadly.

@ctb
Copy link
Contributor Author

ctb commented Feb 23, 2024

note to self - we could implement this as a save plugin pretty easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant