Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lca classify and lca summarize only support JSON query signatures! #1959

Closed
ctb opened this issue Apr 17, 2022 · 4 comments
Closed

lca classify and lca summarize only support JSON query signatures! #1959

ctb opened this issue Apr 17, 2022 · 4 comments

Comments

@ctb
Copy link
Contributor

ctb commented Apr 17, 2022

oops.

they should support the whole panoply of signature loading #1877

@ctb
Copy link
Contributor Author

ctb commented May 4, 2022

ref #1877

@ctb
Copy link
Contributor Author

ctb commented Jul 7, 2022

digging into this a little bit now, and I was somewhat mistaken.

Note that the LCA subcommands take multiple query sigs via --query so they should not use load_query_signature.

src/sourmash/lca/command_classify.py uses sourmash_args.load_file_as_signatures(...), which is pretty generic. It only supports ksize selection and could stand to be upgraded to support moltype selectors, but that's about it.

src/sourmash/lca/command_summarize.py uses MultiIndex.load_from_path, which only loads JSON files. So this could usefully be upgraded to use sourmash_args.load_file_as_signatures(...) I think.

@ctb
Copy link
Contributor Author

ctb commented Jul 7, 2022

note, before closing this when #2107 is merged, we should add an issue about supporting moltype selector on command line.

@ctb
Copy link
Contributor Author

ctb commented Aug 2, 2022

closed by #2107 and addition of #2172

@ctb ctb closed this as completed Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant