Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add_many is super slow in adding large number of kmers #2756

Open
mr-eyes opened this issue Sep 11, 2023 · 1 comment
Open

add_many is super slow in adding large number of kmers #2756

mr-eyes opened this issue Sep 11, 2023 · 1 comment

Comments

@mr-eyes
Copy link
Member

mr-eyes commented Sep 11, 2023 •
edited by ctb
Loading

add_many is super efficient in creating average-size signatures. However, it will be very slow in adding a couple of millions of kmers to a minhash. Probably, it's the Python<->Rust overhead. However, creating the same signature with Python (manually) will be way faster.
@ctb ctb changed the title add_many is super slow in adding large no of kmers add_many is super slow in adding large number of kmers Sep 13, 2023
@ctb
Copy link
Contributor

ctb commented Sep 13, 2023

ref #1617 - remove_many is also very slow on occasion ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ctb @mr-eyes