Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why enforce "email" as metadata for signatures? #292

Closed
phiweger opened this issue Jul 10, 2017 · 1 comment
Closed

Why enforce "email" as metadata for signatures? #292

phiweger opened this issue Jul 10, 2017 · 1 comment

Comments

@phiweger
Copy link

Is there a reason besides "data provenance" why this argument is required? Could you make it optional?

Everything else besides the data about the Minhash (under "signatures") in the .sig.json can be omitted without affecting downstream analyses with e.g. sourmash search (at least it works on a little bit of testing I did).
@ctb
Copy link
Contributor

ctb commented Jul 12, 2017

not really - should be added to #268.

@ctb ctb mentioned this issue Sep 27, 2017
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ctb @phiweger