Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can we store md5sums in the SBT JSON file? #339

Closed
ctb opened this issue Sep 28, 2017 · 6 comments
Closed

can we store md5sums in the SBT JSON file? #339

ctb opened this issue Sep 28, 2017 · 6 comments

Comments

@ctb
Copy link
Contributor

ctb commented Sep 28, 2017

this would let us pick out specific signatures more easily without having to traverse through all the leaves.

@ctb
Copy link
Contributor Author

ctb commented Sep 28, 2017

ref node metadata in #244.

@ctb
Copy link
Contributor Author

ctb commented Jul 3, 2020

ref #993

@ctb
Copy link
Contributor Author

ctb commented Jul 4, 2020

also note, when using md5sum selectors #1072 being able to reach into an SBT and pull out a specific signature quickly seems like a good thing.

@ctb
Copy link
Contributor Author

ctb commented Jul 4, 2020

after revisiting #993 this seems to be already "done", in the sense that md5sums are stored there in several places, most specifically metadata but also in filename and name. What I don't know is which part(s) of this should be/could be guaranteed for SBTs in the future.

@luizirber
Copy link
Member

after revisiting #993 this seems to be already "done", in the sense that md5sums are stored there in several places, most specifically metadata but also in filename and name. What I don't know is which part(s) of this should be/could be guaranteed for SBTs in the future.

metadata. But it should probably be a dictionary, and not just the md5.

"filename" is an IPFS hash for the IPFSStorage, or might contain _0 after the MD5 (dealing with duplicates #994) for ZipStorage and FSStorage.

I think "name" is pretty much unused (because we pull names from the signatures, not the leaf).

@ctb
Copy link
Contributor Author

ctb commented Jun 25, 2021

#1590 adds full manifests to SBTs, that contain all this info!

@ctb ctb closed this as completed Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants