Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--traverse-directory behavior is counterintuitive #836

Closed
ctb opened this issue Jan 8, 2020 · 1 comment · Fixed by #1178
Closed

--traverse-directory behavior is counterintuitive #836

ctb opened this issue Jan 8, 2020 · 1 comment · Fixed by #1178

Comments

@ctb
Copy link
Contributor

ctb commented Jan 8, 2020

Right now, --traverse-directory is a flag that tells various sourmash commands to turn on directory traversal when loading signatures, so that if you give sourmash a directory as a query it will find all the signatures under it. Per #649 this is confusing, and it trips me up conceptually, too.

I'm not sure what a good solution is, but a few thoughts --

  • it would be conceptually simplifying if we allowed directories of signatures as both queries and databases, since sourmash supports both internally...
  • maybe directory traversal could be on by default - if you provide a directory as an argument, it treats it as a collection of signatures? (See also Would a "Directory" Index be useful? #810.) Then --no-directory-traverse or something could be an option. (That doesn't really make sense, tho; maybe just "don't specify a directory on the command line" is better!)

random thoughts, for now. Just recording the convo.

@ctb
Copy link
Contributor Author

ctb commented Jan 19, 2020

this came up in #513 (comment) as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant