[MRG] Make MinHash.downsample(...) require keyword arguments & fix newly revealed buggy test.
#1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctb
changed the title
MinHash.downsample(...) require keyword arguments & fix newly revealed buggy test.MinHash.downsample(...) require keyword arguments & fix newly revealed buggy test.
Codecov Report
@@ Coverage Diff @@
## latest #1448 +/- ##
==========================================
+ Coverage 89.45% 94.60% +5.14%
==========================================
Files 123 96 -27
Lines 19113 15506 -3607
Branches 1471 1472 +1
==========================================
- Hits 17097 14669 -2428
+ Misses 1784 605 -1179
Partials 232 232
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
ready for review @luizirber @bluegenes |
luizirber
approved these changes
Apr 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to provide a parameter as a keyword argument to
MinHash.downsample(...)over in #1392, and it silently did the wrong thing (which was caught by a test, but still).This PR forces keyword arguments in
MinHash.downsample, (i.e. you must provide eithernum=orscaled=). It also catches the exciting new error that I found wherenumdownsampling was mistakenly allowed onscaledsignatures, adds a new (simple) test, and fixes an old test that was erroneously passing to be correctly passing.