Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] add codecov configuration to fix paths #1449

Merged
merged 1 commit into from
Apr 11, 2021
Merged

[MRG] add codecov configuration to fix paths #1449

merged 1 commit into from
Apr 11, 2021

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Apr 11, 2021

This PR adds codecov.yml for configuration of our code coverage reporting at codecov.io so that the paths end up matching the source code paths.

Specifically, since we moved all the source code under src/, but the paths are being reported as sourmash/ instead of src/sourmash/ by our CI environment, codecov can't find the actual source code. This fixes that.

@codecov
Copy link

codecov bot commented Apr 11, 2021

Codecov Report

Merging #1449 (8277399) into latest (29130d2) will increase coverage by 5.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1449      +/-   ##
==========================================
+ Coverage   89.45%   94.60%   +5.14%     
==========================================
  Files         123       96      -27     
  Lines       19120    15506    -3614     
  Branches     1472     1472              
==========================================
- Hits        17104    14669    -2435     
+ Misses       1784      605    -1179     
  Partials      232      232              
Flag Coverage Δ
python 94.60% <ø> (ø)
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test__minhash.py
src/core/tests/minhash.rs
src/sourmash/cli/lca/classify.py
src/sourmash/cli/index.py
src/sourmash/lca/__init__.py
src/sourmash/cli/compute.py
src/sourmash/command_sketch.py
src/core/src/sketch/nodegraph.rs
src/sourmash/lca/lca_utils.py
tests/test_sbt.py
... and 209 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29130d2...8277399. Read the comment docs.

@ctb
Copy link
Contributor Author

ctb commented Apr 11, 2021

I can't tell if this is working yet, I think because codecov isn't necessarily picking up the changed configuration while it's on this branch. @luizirber @bluegenes could I get approval to merge?

@luizirber
Copy link
Member

Hmm, with the way tox is set up we are not really tracking the coverage of the src/ folder, but the installed sourmash package in the venv. For example, if you look at https://github.com/dib-lab/sourmash/runs/2317657067?check_suite_focus=true#step:12:368 you can see it is pointing to /home/runner/work/sourmash/sourmash/.tox/py39/lib/python3.9/site-packages/sourmash/__init__.py

That said, fixing the path with what you added in this PR fixes the problem, so LGTM! =P

@ctb
Copy link
Contributor Author

ctb commented Apr 11, 2021

Exactly. Worth a try, I figure :)

@ctb ctb merged commit 70111f4 into latest Apr 11, 2021
@ctb ctb deleted the fix/codecov_paths branch April 11, 2021 15:53
@luizirber
Copy link
Member

Let's see what happens next time there is a Rust code change, because I think it is going to mess up the report

@ctb
Copy link
Contributor Author

ctb commented Apr 11, 2021

<khan> RUUUUUUUUUUUST! </khan>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants