-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] add codecov configuration to fix paths #1449
Conversation
Codecov Report
@@ Coverage Diff @@
## latest #1449 +/- ##
==========================================
+ Coverage 89.45% 94.60% +5.14%
==========================================
Files 123 96 -27
Lines 19120 15506 -3614
Branches 1472 1472
==========================================
- Hits 17104 14669 -2435
+ Misses 1784 605 -1179
Partials 232 232
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
I can't tell if this is working yet, I think because codecov isn't necessarily picking up the changed configuration while it's on this branch. @luizirber @bluegenes could I get approval to merge? |
Hmm, with the way That said, fixing the path with what you added in this PR fixes the problem, so LGTM! =P |
Exactly. Worth a try, I figure :) |
Let's see what happens next time there is a Rust code change, because I think it is going to mess up the report |
|
This PR adds
codecov.yml
for configuration of our code coverage reporting at codecov.io so that the paths end up matching the source code paths.Specifically, since we moved all the source code under
src/
, but the paths are being reported assourmash/
instead ofsrc/sourmash/
by our CI environment, codecov can't find the actual source code. This fixes that.