-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Debug and fix SBT search #484
Conversation
Codecov Report
@@ Coverage Diff @@
## master #484 +/- ##
=========================================
- Coverage 90.54% 90.5% -0.04%
=========================================
Files 33 33
Lines 4906 4931 +25
Branches 36 36
=========================================
+ Hits 4442 4463 +21
- Misses 463 467 +4
Partials 1 1
Continue to review full report at Codecov.
|
It looks to my naive eye like the problem is due to use of |
@luizirber your thoughts welcome ... might be ready for merging. |
I aggree with the changes, but trying to think how to support them on |
On Mon, Jun 04, 2018 at 01:26:34PM -0700, Luiz Irber wrote:
I aggree with the changes, but trying to think how to support them on `2.0.0a6` without breaking existing DBs (or sourmash installation): probably need to keep `max_n_below` as a synonym for `min_n_below` in the metadata?
I think it _should_ break existing DBs. You can't use existing DBs for search
without getting this parameter set. No?
|
I bumped the version to On the DB side, two things:
|
we should also make available a reasonably sized database (I can use the podar
set) constructed using each important version. I think there's an issue
for this already.
|
We have a persistent problem in that sourmash sbt search does not find everything it should. Containment analysis (sourmash gather) seems to work fine.
First task: figure out how to reproduce it quickly & easily.
utils/check-tree.py
to systematically search trees for their leavesSecond task: scour the codebase with flame and acid.
Ref #244 and #454.
make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?