Skip to content
This repository has been archived by the owner on Apr 23, 2024. It is now read-only.

cache_servicenow task doesn't fail cleanly when credentials are wrong #394

Open
claytonpeters opened this issue Jan 13, 2021 · 0 comments
Open

Comments

@claytonpeters
Copy link
Contributor

When an account has expired / credentials are wrong for ServiceNow, the _cache_servicenow task doesn't fail in the way that you would expect. Each of the downloading data stages "succeed" (even though they clearly can't have done) and then the cache fails with a KeyError on 'result' when trying to re-insert the data after truncating the table.

This should be changed so that each of the download tasks fails cleanly if the login fails

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant