From f13c84b44a01321363c1f8235e3f660978cb4e6e Mon Sep 17 00:00:00 2001 From: Irakli Gotsiridze Date: Thu, 7 Mar 2024 18:07:50 +0400 Subject: [PATCH] remove ext bidfloor --- adapters/sovrn/sovrn.go | 4 - .../both-custom-default-bidfloor.json | 126 ------------------ .../supplemental/only-custom-bidfloor.json | 125 ----------------- .../with-both-custom-default-bidfloor.json | 126 ------------------ .../with-only-custom-bidfloor.json | 125 ----------------- openrtb_ext/imp_sovrn.go | 7 +- static/bidder-params/sovrn.json | 4 - 7 files changed, 3 insertions(+), 514 deletions(-) delete mode 100644 adapters/sovrn/sovrntest/supplemental/both-custom-default-bidfloor.json delete mode 100644 adapters/sovrn/sovrntest/supplemental/only-custom-bidfloor.json delete mode 100644 adapters/sovrn/sovrntest/supplemental/with-both-custom-default-bidfloor.json delete mode 100644 adapters/sovrn/sovrntest/supplemental/with-only-custom-bidfloor.json diff --git a/adapters/sovrn/sovrn.go b/adapters/sovrn/sovrn.go index af60497f93e..beafa3547ab 100644 --- a/adapters/sovrn/sovrn.go +++ b/adapters/sovrn/sovrn.go @@ -75,10 +75,6 @@ func (s *SovrnAdapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *adapt imp.TagID = tagId - if imp.BidFloor == 0 && sovrnExt.BidFloor > 0 { - imp.BidFloor = sovrnExt.BidFloor - } - var impExtBuffer []byte impExtBuffer, err = json.Marshal(&sovrnImpExt{ Bidder: sovrnExt, diff --git a/adapters/sovrn/sovrntest/supplemental/both-custom-default-bidfloor.json b/adapters/sovrn/sovrntest/supplemental/both-custom-default-bidfloor.json deleted file mode 100644 index 4b997b68266..00000000000 --- a/adapters/sovrn/sovrntest/supplemental/both-custom-default-bidfloor.json +++ /dev/null @@ -1,126 +0,0 @@ -{ - "mockBidRequest": { - "id": "test-request-id", - "imp": [ - { - "id": "test-imp-id", - "banner": { - "format": [ - { - "w": 300, - "h": 250 - }, - { - "w": 300, - "h": 600 - } - ] - }, - "bidfloor": 1.69, - "ext": { - "bidder": { - "tagid": "123456", - "bidfloor": 4.20 - } - } - } - ], - "device": { }, - "site": { - "domain": "www.publisher.com", - "page": "http://www.publisher.com/awesome/site" - }, - "user": { - "buyeruid": "test_reader_id" - } - }, - - "httpCalls": [ - { - "expectedRequest": { - "headers": { - "Content-Type": ["application/json"], - "Cookie": ["ljt_reader=test_reader_id"] - }, - "uri": "http://sovrn.com/test/endpoint", - "body": { - "id": "test-request-id", - "imp": [ - { - "id": "test-imp-id", - "banner": { - "format": [ - { - "w": 300, - "h": 250 - }, - { - "w": 300, - "h": 600 - } - ] - }, - "tagid": "123456", - "bidfloor": 1.69, - "ext": { - "bidder": { - "tagid": "123456", - "bidfloor": 4.20 - } - } - } - ], - "site": { - "domain": "www.publisher.com", - "page": "http://www.publisher.com/awesome/site" - }, - "user": { - "buyeruid": "test_reader_id" - }, - "device": { } - } - }, - "mockResponse": { - "status": 200, - "body": { - "id": "test-request-id", - "seatbid": [ - { - "bid": [ - { - "id": "a_449642_554a13d3b9f348fba707cf83f0f63800", - "impid": "test-imp-id", - "price": 3.5, - "nurl": "http://sovrn.com/rtb/impression?bannerid=138743&campaignid=3699&zoneid=449642&cb=69493397&tid=a_449642_554a13d3b9f348fba707cf83f0f63800", - "adm": "some-test-ad", - "w": 300, - "h": 250 - } - ] - } - ] - } - } - } - ], - - "expectedBidResponses": [ - { - "currency": "USD", - "bids": [ - { - "bid": { - "id": "a_449642_554a13d3b9f348fba707cf83f0f63800", - "impid": "test-imp-id", - "price": 3.5, - "adm": "some-test-ad", - "nurl": "http://sovrn.com/rtb/impression?bannerid=138743&campaignid=3699&zoneid=449642&cb=69493397&tid=a_449642_554a13d3b9f348fba707cf83f0f63800", - "w": 300, - "h": 250 - }, - "type": "banner" - } - ] - } - ] -} diff --git a/adapters/sovrn/sovrntest/supplemental/only-custom-bidfloor.json b/adapters/sovrn/sovrntest/supplemental/only-custom-bidfloor.json deleted file mode 100644 index 20c00a48bd2..00000000000 --- a/adapters/sovrn/sovrntest/supplemental/only-custom-bidfloor.json +++ /dev/null @@ -1,125 +0,0 @@ -{ - "mockBidRequest": { - "id": "test-request-id", - "imp": [ - { - "id": "test-imp-id", - "banner": { - "format": [ - { - "w": 300, - "h": 250 - }, - { - "w": 300, - "h": 600 - } - ] - }, - "ext": { - "bidder": { - "tagid": "123456", - "bidfloor": 4.2 - } - } - } - ], - "device": { }, - "site": { - "domain": "www.publisher.com", - "page": "http://www.publisher.com/awesome/site" - }, - "user": { - "buyeruid": "test_reader_id" - } - }, - - "httpCalls": [ - { - "expectedRequest": { - "headers": { - "Content-Type": ["application/json"], - "Cookie": ["ljt_reader=test_reader_id"] - }, - "uri": "http://sovrn.com/test/endpoint", - "body": { - "id": "test-request-id", - "imp": [ - { - "id": "test-imp-id", - "banner": { - "format": [ - { - "w": 300, - "h": 250 - }, - { - "w": 300, - "h": 600 - } - ] - }, - "tagid": "123456", - "bidfloor": 4.2, - "ext": { - "bidder": { - "tagid": "123456", - "bidfloor": 4.2 - } - } - } - ], - "site": { - "domain": "www.publisher.com", - "page": "http://www.publisher.com/awesome/site" - }, - "user": { - "buyeruid": "test_reader_id" - }, - "device": { } - } - }, - "mockResponse": { - "status": 200, - "body": { - "id": "test-request-id", - "seatbid": [ - { - "bid": [ - { - "id": "a_449642_554a13d3b9f348fba707cf83f0f63800", - "impid": "test-imp-id", - "price": 3.5, - "nurl": "http://sovrn.com/rtb/impression?bannerid=138743&campaignid=3699&zoneid=449642&cb=69493397&tid=a_449642_554a13d3b9f348fba707cf83f0f63800", - "adm": "some-test-ad", - "w": 300, - "h": 250 - } - ] - } - ] - } - } - } - ], - - "expectedBidResponses": [ - { - "currency": "USD", - "bids": [ - { - "bid": { - "id": "a_449642_554a13d3b9f348fba707cf83f0f63800", - "impid": "test-imp-id", - "price": 3.5, - "adm": "some-test-ad", - "nurl": "http://sovrn.com/rtb/impression?bannerid=138743&campaignid=3699&zoneid=449642&cb=69493397&tid=a_449642_554a13d3b9f348fba707cf83f0f63800", - "w": 300, - "h": 250 - }, - "type": "banner" - } - ] - } - ] -} diff --git a/adapters/sovrn/sovrntest/supplemental/with-both-custom-default-bidfloor.json b/adapters/sovrn/sovrntest/supplemental/with-both-custom-default-bidfloor.json deleted file mode 100644 index 4b997b68266..00000000000 --- a/adapters/sovrn/sovrntest/supplemental/with-both-custom-default-bidfloor.json +++ /dev/null @@ -1,126 +0,0 @@ -{ - "mockBidRequest": { - "id": "test-request-id", - "imp": [ - { - "id": "test-imp-id", - "banner": { - "format": [ - { - "w": 300, - "h": 250 - }, - { - "w": 300, - "h": 600 - } - ] - }, - "bidfloor": 1.69, - "ext": { - "bidder": { - "tagid": "123456", - "bidfloor": 4.20 - } - } - } - ], - "device": { }, - "site": { - "domain": "www.publisher.com", - "page": "http://www.publisher.com/awesome/site" - }, - "user": { - "buyeruid": "test_reader_id" - } - }, - - "httpCalls": [ - { - "expectedRequest": { - "headers": { - "Content-Type": ["application/json"], - "Cookie": ["ljt_reader=test_reader_id"] - }, - "uri": "http://sovrn.com/test/endpoint", - "body": { - "id": "test-request-id", - "imp": [ - { - "id": "test-imp-id", - "banner": { - "format": [ - { - "w": 300, - "h": 250 - }, - { - "w": 300, - "h": 600 - } - ] - }, - "tagid": "123456", - "bidfloor": 1.69, - "ext": { - "bidder": { - "tagid": "123456", - "bidfloor": 4.20 - } - } - } - ], - "site": { - "domain": "www.publisher.com", - "page": "http://www.publisher.com/awesome/site" - }, - "user": { - "buyeruid": "test_reader_id" - }, - "device": { } - } - }, - "mockResponse": { - "status": 200, - "body": { - "id": "test-request-id", - "seatbid": [ - { - "bid": [ - { - "id": "a_449642_554a13d3b9f348fba707cf83f0f63800", - "impid": "test-imp-id", - "price": 3.5, - "nurl": "http://sovrn.com/rtb/impression?bannerid=138743&campaignid=3699&zoneid=449642&cb=69493397&tid=a_449642_554a13d3b9f348fba707cf83f0f63800", - "adm": "some-test-ad", - "w": 300, - "h": 250 - } - ] - } - ] - } - } - } - ], - - "expectedBidResponses": [ - { - "currency": "USD", - "bids": [ - { - "bid": { - "id": "a_449642_554a13d3b9f348fba707cf83f0f63800", - "impid": "test-imp-id", - "price": 3.5, - "adm": "some-test-ad", - "nurl": "http://sovrn.com/rtb/impression?bannerid=138743&campaignid=3699&zoneid=449642&cb=69493397&tid=a_449642_554a13d3b9f348fba707cf83f0f63800", - "w": 300, - "h": 250 - }, - "type": "banner" - } - ] - } - ] -} diff --git a/adapters/sovrn/sovrntest/supplemental/with-only-custom-bidfloor.json b/adapters/sovrn/sovrntest/supplemental/with-only-custom-bidfloor.json deleted file mode 100644 index b4ab404e9be..00000000000 --- a/adapters/sovrn/sovrntest/supplemental/with-only-custom-bidfloor.json +++ /dev/null @@ -1,125 +0,0 @@ -{ - "mockBidRequest": { - "id": "test-request-id", - "imp": [ - { - "id": "test-imp-id", - "banner": { - "format": [ - { - "w": 300, - "h": 250 - }, - { - "w": 300, - "h": 600 - } - ] - }, - "ext": { - "bidder": { - "tagid": "123456", - "bidfloor": 4.2 - } - } - } - ], - "device": { }, - "site": { - "domain": "www.publisher.com", - "page": "http://www.publisher.com/awesome/site" - }, - "user": { - "buyeruid": "test_reader_id" - } - }, - - "httpCalls": [ - { - "expectedRequest": { - "headers": { - "Content-Type": ["application/json"], - "Cookie": ["ljt_reader=test_reader_id"] - }, - "uri": "http://sovrn.com/test/endpoint", - "body": { - "id": "test-request-id", - "imp": [ - { - "id": "test-imp-id", - "banner": { - "format": [ - { - "w": 300, - "h": 250 - }, - { - "w": 300, - "h": 600 - } - ] - }, - "bidfloor": 4.2, - "tagid": "123456", - "ext": { - "bidder": { - "tagid": "123456", - "bidfloor": 4.20 - } - } - } - ], - "site": { - "domain": "www.publisher.com", - "page": "http://www.publisher.com/awesome/site" - }, - "user": { - "buyeruid": "test_reader_id" - }, - "device": { } - } - }, - "mockResponse": { - "status": 200, - "body": { - "id": "test-request-id", - "seatbid": [ - { - "bid": [ - { - "id": "a_449642_554a13d3b9f348fba707cf83f0f63800", - "impid": "test-imp-id", - "price": 3.5, - "nurl": "http://sovrn.com/rtb/impression?bannerid=138743&campaignid=3699&zoneid=449642&cb=69493397&tid=a_449642_554a13d3b9f348fba707cf83f0f63800", - "adm": "some-test-ad", - "w": 300, - "h": 250 - } - ] - } - ] - } - } - } - ], - - "expectedBidResponses": [ - { - "currency": "USD", - "bids": [ - { - "bid": { - "id": "a_449642_554a13d3b9f348fba707cf83f0f63800", - "impid": "test-imp-id", - "price": 3.5, - "adm": "some-test-ad", - "nurl": "http://sovrn.com/rtb/impression?bannerid=138743&campaignid=3699&zoneid=449642&cb=69493397&tid=a_449642_554a13d3b9f348fba707cf83f0f63800", - "w": 300, - "h": 250 - }, - "type": "banner" - } - ] - } - ] -} diff --git a/openrtb_ext/imp_sovrn.go b/openrtb_ext/imp_sovrn.go index 362463f9513..f32ae262a28 100644 --- a/openrtb_ext/imp_sovrn.go +++ b/openrtb_ext/imp_sovrn.go @@ -1,8 +1,7 @@ package openrtb_ext type ExtImpSovrn struct { - TagId string `json:"tagId,omitempty"` - Tagid string `json:"tagid,omitempty"` - BidFloor float64 `json:"bidfloor,omitempty"` - AdUnitCode string `json:"adunitcode,omitempty"` + TagId string `json:"tagId,omitempty"` + Tagid string `json:"tagid,omitempty"` + AdUnitCode string `json:"adunitcode,omitempty"` } diff --git a/static/bidder-params/sovrn.json b/static/bidder-params/sovrn.json index d821a808f97..68d9e56b62e 100644 --- a/static/bidder-params/sovrn.json +++ b/static/bidder-params/sovrn.json @@ -13,10 +13,6 @@ "type": "string", "description": "An ID which identifies the sovrn ad tag (DEPRECATED, use \"tagid\" instead)" }, - "bidfloor": { - "type": "number", - "description": "The minimium acceptable bid, in CPM, using US Dollars" - }, "adunitcode": { "type": "string", "description": "The string which identifies Ad Unit"