Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post build checks that there is no /opt/ros #187

Open
asimonov opened this issue Sep 10, 2024 · 1 comment
Open

Add post build checks that there is no /opt/ros #187

asimonov opened this issue Sep 10, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@asimonov
Copy link

Feature description

After every image build check that /opt/ros does not exist. If there is, it indicates that we missed an apt install of some ros package that in turn brings other dependencies. We should only build from source to not mix in packages from apt

Implementation considerations

Post build workflow check

@Bckempa
Copy link
Contributor

Bckempa commented Sep 19, 2024

We should also inspect the workspace precedence of the colon generated install.sh scripts to make sure we don't have any unexpected underlays. If you look in the release images now you can see it actually sources the /opt/ros/humble/ local install... oops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants