feat: implement inequality post processing for timestamps #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dustin-Ray
force-pushed
the
feat/timestamp-inequality-postprocessing
branch
from
bd31555
to
d6335cc
Compare
Dustin-Ray
force-pushed
the
feat/timestamp-inequality-postprocessing
branch
from
80cf850
to
1ddefc3
Compare
Dustin-Ray
force-pushed
the
feat/timestamp-inequality-postprocessing
branch
from
1ddefc3
to
5a68319
Compare
iajoiner
reviewed
Sep 17, 2024
| (PoSQLTimeUnit::Second, PoSQLTimeUnit::Nanosecond) => timestamp * 1_000_000_000, | ||
|
|
||
| // Conversions from Milliseconds | ||
| (PoSQLTimeUnit::Millisecond, PoSQLTimeUnit::Second) => timestamp / 1000, |
There was a problem hiding this comment.
Hmm if we accept rounding then 10AM and 10AM plus 1ms will be identical if we normalize to s.
There was a problem hiding this comment.
Ok no rounding, got it
iajoiner
reviewed
Sep 17, 2024
|
|
||
| #[test] | ||
| fn test_normalize_timeunit_milliseconds_to_seconds() { | ||
| let timestamp = 1231006505000; // milliseconds |
There was a problem hiding this comment.
What about 1231006505001? normalize_timeunit(1231006505000, MS, S) == normalize_timeunit(1231006505001, MS, S)
iajoiner
reviewed
Sep 17, 2024
fix: add tests fix: tests fix: docs and tests
Dustin-Ray
force-pushed
the
feat/timestamp-inequality-postprocessing
branch
from
3d8ed68
to
9f20edd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Postprocessing was left out as a fast-follow for the TimestampTZ provable datatype. This PR introduces support for it, as a mitigation to #149.
What changes are included in this PR?
Are these changes tested?