Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage of deprecated library code #1732

Closed
julianbraha opened this issue Nov 4, 2023 · 0 comments · Fixed by #1733
Closed

Usage of deprecated library code #1732

julianbraha opened this issue Nov 4, 2023 · 0 comments · Fixed by #1733
Labels
kind/bug Something isn't working status/needs-triage

Comments

@julianbraha
Copy link
Contributor

Describe the bug

The p2p crate has deprecated ConnectionHandler::Error, and will be removing it soon.

See:

  1. swarm: Remove ConnectionHandler::Error libp2p/rust-libp2p#3591
  2. feat(swarm): deprecate ConnectionHandlerEvent::Close libp2p/rust-libp2p#4714

Instead of using #[allow(deprecated)], it would be better to use StreamUpgradeError<io::Error>.

Reproduction

No response

Expected behavior

No response

Platform and versions

Output of `pnpm --version && cargo --version && rustc --version`:

8.10.2
cargo 1.73.0 (9c4383fb5 2023-08-26)
rustc 1.73.0 (cc66ad468 2023-10-03)

OS: EndeavourOS (rolling release)



### Stack trace

_No response_

### Additional context

_No response_
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working status/needs-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace deprecated ConnectionHandler::Error
1 participant
@julianbraha