Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible issues with routing discovery mechanism #5978

Open
ivan4th opened this issue May 24, 2024 · 0 comments
Open

Possible issues with routing discovery mechanism #5978

ivan4th opened this issue May 24, 2024 · 0 comments
Labels

Comments

@ivan4th
Copy link
Contributor

ivan4th commented May 24, 2024

Description

Currently, we're using a single DHT for both LAN and WAN. This means that libp2p-kad-dht's IP diversity filter is not being used for the peers participating in the DHT, leaving possibilities to some kinds of eclipse attacks. We should switch to dual DHT (LAN and WAN) like what's used in Kubo. See here for more info on built-in DHT eclipse attack protection. Besides IP diversity filters, switching to Dual DHT is going to fix the issues with peers that have private IPs: #5510

A related problem is random peer selection during routing discovery. In theory, it is possible to poison DHT in a way so that a predictable set of peers is found via FindProviders mechanism used by routing discovery. But applying IP diversity filters for WAN IPs is also going to make this kind of attack substantially harder and likely too expensive too implement.

@ivan4th ivan4th added the bug label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant