From 0c01270d0584ca3dd50c857f46329d200787a02e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ru=20Ke=C3=AFn?= <3181182+alphasentaurii@users.noreply.github.com> Date: Thu, 17 Aug 2023 15:20:16 -0400 Subject: [PATCH] tests/roman-metrics-logger-decorators (#943) * added metrics logger DMS tags to relevant Roman tests * update changelog * added metrics-logger to test deps --- CHANGES.rst | 8 ++++++++ crds/tests/test_roman.py | 9 ++++++--- pyproject.toml | 1 + 3 files changed, 15 insertions(+), 3 deletions(-) diff --git a/CHANGES.rst b/CHANGES.rst index 1e15d5904..073eaa762 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -1,3 +1,11 @@ +11.17.3 (unreleased) +==================== + +ROMAN +----- + +- Added metrics-logger decorators with DMS tags to appropriate Roman tests [#943] + 11.17.2 (2023-06-29) ==================== diff --git a/crds/tests/test_roman.py b/crds/tests/test_roman.py index 4593a69d8..b01c5bd79 100644 --- a/crds/tests/test_roman.py +++ b/crds/tests/test_roman.py @@ -8,7 +8,7 @@ from crds.tests import test_config from nose.tools import raises - +from metrics_logger.decorators import metrics_logger class TestRoman(unittest.TestCase): """ TestRoman is a collection of crds unit tests for ROMAN. @@ -23,6 +23,7 @@ def setUp(self): def tearDown(self): test_config.cleanup(self.old_state) + @metrics_logger("DMS16", "DMS25") def test_getreferences_with_valid_header_ISOT_fmt(self): """ test_getreferences_with_valid_header: test satisfies Roman 303.1 and 628.1 """ @@ -39,7 +40,8 @@ def test_getreferences_with_valid_header_ISOT_fmt(self): ) assert pathlib.Path(result["dark"]).name == "roman_wfi_dark_0001.asdf" - + + @metrics_logger("DMS16", "DMS25", "DMS26") def test_getreferences_with_valid_header_ISO_fmt(self): """ test_getreferences_with_valid_header: test satisfies Roman 303.1 and 628.1 """ @@ -86,7 +88,7 @@ def test_getreferences_with_valid_header_ISO_fmt(self): assert pathlib.Path(result["distortion"]).name == "roman_wfi_distortion_0001.asdf" - + @metrics_logger("DMS16") @raises(CrdsLookupError) def test_getreferences_with_invalid_header(self): """ test_getreferences_with_invalid_header: test satisfies Roman 303.1 @@ -103,6 +105,7 @@ def test_getreferences_with_invalid_header(self): reftypes=["dark"] ) + @metrics_logger("DMS114", "DMS25", "DMS26") def test_list_references(self): """ test_list_references: test satisfies Roman 303.2 and 628.2 """ diff --git a/pyproject.toml b/pyproject.toml index b06758265..e3b3b70aa 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -45,6 +45,7 @@ test = [ "flake8", "bandit", "coverage", + "metrics-logger", ] docs = [ "sphinx",