Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Have the region-select tool also be selectable from the aperture photometry plugin #2547

Open
eteq opened this issue Nov 1, 2023 · 2 comments
Labels
feature Feature request imviz

Comments

@eteq
Copy link
Contributor

eteq commented Nov 1, 2023

Jdaviz component

Imviz

What is the problem this feature will solve?

When using the aperture photometry plugin, one has to know to click ouside of the plugin to create an aperture/subset. That's a bit disruptive of the mental workflow because I would have expected to click somewhere in the plugin.

Describe the desired outcome

Anything in the plugin that would allow this would work. A few options include:

  1. Have the subset button from the toolbar appear somewhere in the apphot plugin. This would just be a convenient duplicate that would otherwise be identical in functionality to the button (and linked with it, presumably)
  2. Have a special option for when no subset exists that's something like "create new..." which then programatically goes and "clicks" the subset button in whatever mode it's currently in.
  3. Have some text that says "not sure how to create an aperture? click the icon that looks like to create a subset"

Additional context

🐱

@eteq eteq added feature Feature request needs-triage Issue opened via template and needs triaging labels Nov 1, 2023
@pllim
Copy link
Contributor

pllim commented Nov 1, 2023

(3) Might be the most feasible because the other ones will duplicate existing functionality in Subset Tools.

@pllim pllim added imviz and removed needs-triage Issue opened via template and needs triaging labels Nov 1, 2023
@kecnry
Copy link
Member

kecnry commented Nov 2, 2023

The solution here could be combined with #2546 - if there are no subsets, show an alert dialog along with a button to activate the tool. The slight problem with that is there could be multiple viewers, so do we activate the tool in all viewers, just the default, provide a button for each viewer, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request imviz
Projects
None yet
Development

No branches or pull requests

3 participants