-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the cursor display formatting for imviz #598
Comments
Now my opinions
|
|
This comment has been minimized.
This comment has been minimized.
Update: I added screenshots from DS9 vs Imviz for two sample images at the same pixels, respectively, above. My response to the opinions and requests as follow:
|
I have 2 UX concerns. Neither mean this can't be shipped as is, but we may consider turning them into a bug/ticket to address in the future.
|
Reply from @PatrickOgle on Slack:
|
@Jenneh @pllim - I'd be happy to work on any UI tweaks. I do see approximately equal padding on the top and bottom (although it is small - but the screenshots might slightly crop out in some cases). The only ways to increase padding would be to decrease font size, increase height of the app toolbar further, or remove the three lines (likely with a switch, but that is in conflict with the "scientists want both". |
@kecnry , it looks fine in Notebook but bottom padding gone in Lab. Is Lab using a different CSS or something? |
This is a follow-on to #557 / #514. Below is a screenshot of the current look for imviz following those PRs:
Basically, after several scientists looked at this (@orifox, @camipacifici, @PatrickOgle, and myself), we hit several points of concern. All of these are debatable and somewhat subjective, so this is starting as a space to try to come to consensus. The specific concerns were:
pixels
field should not be 0-padded.value
shouldn't be in scientific notation for small numbersvalue
first or last rather than in between pixel and world.(I'll leave a comment with my opinion on this)
cc @Jenneh @astrofrog @pllim
The text was updated successfully, but these errors were encountered: