You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is an outgrowth from #622 / #630 / #632- after some out-of-band conversations (esp with @pllim and @astrofrog), we realized that the concept of "regions" that we are getting from glue's subsets are not quite comparable to ds9-style regions. The regions we're using right now in jdaviz aren't really scalable to even many 10s, much less the 1000s or more that are often needed when you want to mark all the objects of some type in a typical astronomical image.
So this issue proposes instead that we split our existing "regions" concept into "regions" and "makers". Regions map onto the glue concept of subsets, meaning interactively selectable and grabbable in the notebook as a mask or astropy region or the like. Markers are more like the marks that astrowidgets uses, and more like what happens when you load a large table of point or circles into ds9 as "regions".
So this issue suggests a minimal marker implementation
Markers are the standard glue-jupyter/bqplot scallter plot.
Only usable from the notebook with a "live" astropy table (can later implement this as a plugin, but initially only in the notebook). The minimal implementation is just add_markers from astrowidgets, remove_markers from astrowidgets, and maybe reset_markers from astrowidgets
If there are multiple viewers up, it just runs on all the viewers by default. Option on (if it's easy), adding a keyword to add_markers/remove_markers to reference a viewer by name (reset would just reset everything), but that's not the minimal case, so if that's too complicated, all is sufficient.
OK, this glupyter example really helped a lot. The mapping from native glupyter to jdaviz was less obvious but I think I got it with some trial and error.
This is an outgrowth from #622 / #630 / #632- after some out-of-band conversations (esp with @pllim and @astrofrog), we realized that the concept of "regions" that we are getting from glue's subsets are not quite comparable to ds9-style regions. The regions we're using right now in
jdaviz
aren't really scalable to even many 10s, much less the 1000s or more that are often needed when you want to mark all the objects of some type in a typical astronomical image.So this issue proposes instead that we split our existing "regions" concept into "regions" and "makers". Regions map onto the glue concept of subsets, meaning interactively selectable and grabbable in the notebook as a mask or astropy region or the like. Markers are more like the marks that astrowidgets uses, and more like what happens when you load a large table of point or circles into ds9 as "regions".
So this issue suggests a minimal marker implementation
add_markers
from astrowidgets,remove_markers
from astrowidgets, and maybereset_markers
from astrowidgetsadd_markers
/remove_markers
to reference a viewer by name (reset
would just reset everything), but that's not the minimal case, so if that's too complicated, all is sufficient.🐱
The text was updated successfully, but these errors were encountered: