test_astrometric_utils failures on main branch

[braingram]

11 tests suddenly started failing in test_astrometric_utils.py.
https://github.com/spacetelescope/romancal/actions/runs/6394475030/job/17355965466#step:10:201

@mairanteodoro any initial thoughts on why these might be failing?

FAILED romancal/tweakreg/tests/test_astrometric_utils.py::test_get_catalog_using_epoch[10-10-2000] - assert False
 +  where False = <built-in method all of numpy.ndarray object at 0x7fa17feabe70>()
 +    where <built-in method all of numpy.ndarray object at 0x7fa17feabe70> = array([False, False, False, False, False, False, False, False,  True,\n       False,  True, False, False, False, False,...False, False, False,\n       False, False, False, False, False, False, False, False,  True,\n       False, False, False]).all
 +      where array([False, False, False, False, False, False, False, False,  True,\n       False,  True, False, False, False, False,...False, False, False,\n       False, False, False, False, False, False, False, False,  True,\n       False, False, False]) = <function isclose at 0x7fa1ac1bbdb0>(array([ 9.99259107,  9.98845403,  9.98513531,  9.99349667, 10.00546396,\n        9.98691049, 10.01945872,  9.96919236, ...\n       10.08310588, 10.06293681, 10.01253871, 10.05945472,  9.90433175,\n       10.09693267, 10.00078586, 10.00124519]), array([ 9.99259109,  9.98845432,  9.98513556,  9.9934973 , 10.00546421,\n        9.98691121, 10.01945864,  9.96919267, ...\n       10.08310596, 10.06293726, 10.01253885, 10.0594541 ,  9.90433175,\n       10.09693307, 10.00078581, 10.00124548]), atol=1e-10, rtol=1e-09)
 +        where <function isclose at 0x7fa1ac1bbdb0> = np.isclose
FAILED romancal/tweakreg/tests/test_astrometric_utils.py::test_get_catalog_using_epoch[10-10-2010.3] - assert False
 +  where False = <built-in method all of numpy.ndarray object at 0x7fa17fc8fbd0>()
 +    where <built-in method all of numpy.ndarray object at 0x7fa17fc8fbd0> = array([ True, False, False, False, False, False, False, False,  True,\n       False,  True, False, False, False, False,...False, False, False,\n       False, False, False, False, False, False, False, False,  True,\n       False, False, False]).all
 +      where array([ True, False, False, False, False, False, False, False,  True,\n       False,  True, False, False, False, False,...False, False, False,\n       False, False, False, False, False, False, False, False,  True,\n       False, False, False]) = <function isclose at 0x7fa1ac1bbdb0>(array([ 9.99259983,  9.98849761,  9.98518264,  9.99369649, 10.00553104,\n        9.98694363, 10.01946882,  9.96919106, ...\n       10.08308708, 10.06298964, 10.0125266 , 10.05945205,  9.90433175,\n       10.09685176, 10.00078143, 10.00125861]), array([ 9.99259982,  9.98849752,  9.98518256,  9.99369628, 10.00553096,\n        9.98694339, 10.01946884,  9.96919096, ...\n       10.08308705, 10.0629895 , 10.01252655, 10.05945225,  9.90433175,\n       10.09685162, 10.00078145, 10.00125851]), atol=1e-10, rtol=1e-09)
 +        where <function isclose at 0x7fa1ac1bbdb0> = np.isclose
FAILED romancal/tweakreg/tests/test_astrometric_utils.py::test_get_catalog_using_epoch[10-10-2030] - assert False
 +  where False = <built-in method all of numpy.ndarray object at 0x7fa17fc8c450>()
 +    where <built-in method all of numpy.ndarray object at 0x7fa17fc8c450> = array([False, False, False, False, False, False, False, False,  True,\n       False,  True, False, False, False, False,...False, False, False,\n       False, False, False, False, False, False, False, False,  True,\n       False, False, False]).all
 +      where array([False, False, False, False, False, False, False, False,  True,\n       False,  True, False, False, False, False,...False, False, False,\n       False, False, False, False, False, False, False, False,  True,\n       False, False, False]) = <function isclose at 0x7fa1ac1bbdb0>(array([ 9.99261649,  9.98857982,  9.9852722 ,  9.99407622, 10.00565838,\n        9.98700421, 10.01948843,  9.96918739, ...\n       10.08305081, 10.06308895, 10.01250288, 10.05944931,  9.90433175,\n       10.09669544, 10.00077315, 10.00128315]), array([ 9.99261651,  9.98858012,  9.98527245,  9.99407685, 10.00565862,\n        9.98700494, 10.01948836,  9.9691877 , ...\n       10.08305089, 10.0630894 , 10.01250303, 10.0594487 ,  9.90433175,\n       10.09669584, 10.0007731 , 10.00128343]), atol=1e-10, rtol=1e-09)
 +        where <function isclose at 0x7fa1ac1bbdb0> = np.isclose
FAILED romancal/tweakreg/tests/test_astrometric_utils.py::test_get_catalog_using_epoch[10--10-2000] - assert False
 +  where False = <built-in method all of numpy.ndarray object at 0x7fa17fc3fe10>()
 +    where <built-in method all of numpy.ndarray object at 0x7fa17fc3fe10> = array([False, False, False, False, False, False, False, False, False,\n       False, False, False,  True, False, False,...False,  True,  True, False,\n       False, False, False, False,  True,  True, False, False, False,\n        True,  True]).all
 +      where array([False, False, False, False, False, False, False, False, False,\n       False, False, False,  True, False, False,...False,  True,  True, False,\n       False, False, False, False,  True,  True, False, False, False,\n        True,  True]) = <function isclose at 0x7fa1ac1bbdb0>(array([10.02207015, 10.02572376, 10.00266843, 10.00311102,  9.96678232,\n       10.03435959,  9.95908016, 10.03813507, ... 10.04084457,\n        9.91057979, 10.09774014,  9.99951116,  9.93962273, 10.07684888,\n       10.0430036 ,  9.94210507]), array([10.02207052, 10.02572307, 10.00266951, 10.0031122 ,  9.96678302,\n       10.03435971,  9.95908068, 10.03813546, ... 10.04084439,\n        9.91057979, 10.09774014,  9.99951121,  9.93962314, 10.0768493 ,\n       10.0430036 ,  9.94210507]), atol=1e-10, rtol=1e-09)
 +        where <function isclose at 0x7fa1ac1bbdb0> = np.isclose
FAILED romancal/tweakreg/tests/test_astrometric_utils.py::test_get_catalog_using_epoch[10--10-2010.3] - assert False
 +  where False = <built-in method all of numpy.ndarray object at 0x7fa17fc50ff0>()
 +    where <built-in method all of numpy.ndarray object at 0x7fa17fc50ff0> = array([False, False, False, False, False, False, False, False, False,\n       False, False, False,  True, False, False,...False,  True,  True, False,\n        True, False, False, False,  True,  True, False, False, False,\n        True,  True]).all
 +      where array([False, False, False, False, False, False, False, False, False,\n       False, False, False,  True, False, False,...False,  True,  True, False,\n        True, False, False, False,  True,  True, False, False, False,\n        True,  True]) = <function isclose at 0x7fa1ac1bbdb0>(array([10.02208723, 10.02571509, 10.00281682, 10.00325934,  9.96674903,\n       10.03435948,  9.95908418, 10.03815838, ... 10.04084996,\n        9.91057979, 10.09774014,  9.99951577,  9.93964767, 10.07681891,\n       10.0430036 ,  9.94210507]), array([10.02208711, 10.02571532, 10.00281647, 10.00325895,  9.9667488 ,\n       10.03435945,  9.95908401, 10.03815825, ... 10.04085002,\n        9.91057979, 10.09774014,  9.99951576,  9.93964753, 10.07681877,\n       10.0430036 ,  9.94210507]), atol=1e-10, rtol=1e-09)
 +        where <function isclose at 0x7fa1ac1bbdb0> = np.isclose
FAILED romancal/tweakreg/tests/test_astrometric_utils.py::test_get_catalog_using_epoch[10--10-2030] - assert False
 +  where False = <built-in method all of numpy.ndarray object at 0x7fa17fc4c750>()
 +    where <built-in method all of numpy.ndarray object at 0x7fa17fc4c750> = array([False, False, False, False, False, False, False, False, False,\n       False, False, False,  True, False, False,...False,  True,  True, False,\n       False, False, False, False,  True,  True, False, False, False,\n        True,  True]).all
 +      where array([False, False, False, False, False, False, False, False, False,\n       False, False, False,  True, False, False,...False,  True,  True, False,\n       False, False, False, False,  True,  True, False, False, False,\n        True,  True]) = <function isclose at 0x7fa1ac1bbdb0>(array([10.02211845, 10.02570118, 10.00309645, 10.00353847,  9.96668265,\n       10.03435884,  9.95908986, 10.03820146, ... 10.04086095,\n        9.91057979, 10.09774014,  9.9995244 ,  9.93969377, 10.07675995,\n       10.0430036 ,  9.94210507]), array([10.02211883, 10.02570049, 10.00309753, 10.00353964,  9.96668334,\n       10.03435895,  9.95909037, 10.03820185, ... 10.04086077,\n        9.91057979, 10.09774014,  9.99952446,  9.93969419, 10.07676037,\n       10.0430036 ,  9.94210507]), atol=1e-10, rtol=1e-09)
 +        where <function isclose at 0x7fa1ac1bbdb0> = np.isclose
FAILED romancal/tweakreg/tests/test_astrometric_utils.py::test_get_catalog_using_epoch[0-0-2000] - assert False
 +  where False = <built-in method all of numpy.ndarray object at 0x7fa17fc4ce10>()
 +    where <built-in method all of numpy.ndarray object at 0x7fa17fc4ce10> = array([False, False,  True,  True, False,  True, False, False,  True,\n       False, False,  True, False, False,  True,... True, False, False,  True,  True, False,  True, False,\n       False, False,  True, False, False, False,  True,  True]).all
 +      where array([False, False,  True,  True, False,  True, False, False,  True,\n       False, False,  True, False, False,  True,... True, False, False,  True,  True, False,  True, False,\n       False, False,  True, False, False, False,  True,  True]) = <function isclose at 0x7fa1ac1bbdb0>(array([9.46050024e-03, 3.59989571e+02, 3.59981923e+02, 3.59980023e+02,\n       3.59977531e+02, 3.59989287e+02, 3.060245...001e-02, 3.59930776e+02,\n       3.59916778e+02, 3.59916677e+02, 4.46524825e-02, 3.59938945e+02,\n       3.59920968e+02]), array([9.46094931e-03, 3.59989571e+02, 3.59981923e+02, 3.59980023e+02,\n       3.59977532e+02, 3.59989288e+02, 3.060266...946e-02, 3.59930776e+02,\n       3.59916779e+02, 3.59916678e+02, 4.46531827e-02, 3.59938945e+02,\n       3.59920968e+02]), atol=1e-10, rtol=1e-09)
 +        where <function isclose at 0x7fa1ac1bbdb0> = np.isclose
FAILED romancal/tweakreg/tests/test_astrometric_utils.py::test_get_catalog_using_epoch[0-0-2010.3] - assert False
 +  where False = <built-in method all of numpy.ndarray object at 0x7fa180138090>()
 +    where <built-in method all of numpy.ndarray object at 0x7fa180138090> = array([False,  True,  True,  True, False,  True, False, False,  True,\n       False, False,  True, False, False,  True,... True, False, False,  True,  True, False,  True, False,\n       False, False,  True, False, False, False,  True,  True]).all
 +      where array([False,  True,  True,  True, False,  True, False, False,  True,\n       False, False,  True, False, False,  True,... True, False, False,  True,  True, False,  True, False,\n       False, False,  True, False, False, False,  True,  True]) = <function isclose at 0x7fa1ac1bbdb0>(array([9.44570801e-03, 3.59989567e+02, 3.59981954e+02, 3.59980033e+02,\n       3.59977549e+02, 3.59989336e+02, 3.063115...720e-02, 3.59930770e+02,\n       3.59916772e+02, 3.59916677e+02, 4.46019055e-02, 3.59938945e+02,\n       3.59920961e+02]), array([9.44547657e-03, 3.59989567e+02, 3.59981954e+02, 3.59980033e+02,\n       3.59977549e+02, 3.59989336e+02, 3.063104...235e-02, 3.59930770e+02,\n       3.59916771e+02, 3.59916677e+02, 4.46015451e-02, 3.59938945e+02,\n       3.59920961e+02]), atol=1e-10, rtol=1e-09)
 +        where <function isclose at 0x7fa1ac1bbdb0> = np.isclose
FAILED romancal/tweakreg/tests/test_astrometric_utils.py::test_get_catalog_using_epoch[0-0-2030] - assert False
 +  where False = <built-in method all of numpy.ndarray object at 0x7fa180138cf0>()
 +    where <built-in method all of numpy.ndarray object at 0x7fa180138cf0> = array([False, False,  True,  True, False,  True, False, False,  True,\n       False, False,  True, False, False,  True,... True, False, False,  True,  True, False,  True, False,\n       False, False,  True, False, False, False,  True,  True]).all
 +      where array([False, False,  True,  True, False,  True, False, False,  True,\n       False, False,  True, False, False,  True,... True, False, False,  True,  True, False,  True, False,\n       False, False,  True, False, False, False,  True,  True]) = <function isclose at 0x7fa1ac1bbdb0>(array([9.41543359e-03, 3.59989559e+02, 3.59982014e+02, 3.59980052e+02,\n       3.59977579e+02, 3.59989428e+02, 3.068510...122e-02, 3.59930758e+02,\n       3.59916754e+02, 3.59916672e+02, 4.45020812e-02, 3.59938945e+02,\n       3.59920947e+02]), array([9.41588307e-03, 3.59989559e+02, 3.59982014e+02, 3.59980052e+02,\n       3.59977580e+02, 3.59989428e+02, 3.068531...068e-02, 3.59930758e+02,\n       3.59916756e+02, 3.59916673e+02, 4.45027820e-02, 3.59938945e+02,\n       3.59920947e+02]), atol=1e-10, rtol=1e-09)
 +        where <function isclose at 0x7fa1ac1bbdb0> = np.isclose
FAILED romancal/tweakreg/tests/test_astrometric_utils.py::test_get_catalog_using_epoch[269.4521-4.6933-2030] - assert False
 +  where False = <built-in method all of numpy.ndarray object at 0x7fa17fa36730>()
 +    where <built-in method all of numpy.ndarray object at 0x7fa17fa36730> = array([ True,  True,  True, ...,  True,  True,  True]).all
 +      where array([ True,  True,  True, ...,  True,  True,  True]) = <function isclose at 0x7fa1ac1bbdb0>(array([269.45356629, 269.452091  , 269.44731469, ..., 269.53815611,\n       269.53551887, 269.48125526]), array([269.45356628, 269.45209108, 269.44731468, ..., 269.53815611,\n       269.53551885, 269.48125523]), atol=1e-10, rtol=1e-09)
 +        where <function isclose at 0x7fa1ac1bbdb0> = np.isclose
FAILED romancal/tweakreg/tests/test_astrometric_utils.py::test_get_catalog_using_epoch[89-80-2010] - assert False
 +  where False = <built-in method all of numpy.ndarray object at 0x7fa1801a8090>()
 +    where <built-in method all of numpy.ndarray object at 0x7fa1801a8090> = array([ True,  True, False, False, False, False, False, False, False,\n       False, False,  True,  True,  True, False,... True, False, False, False, False, False, False, False,  True,\n        True, False,  True, False,  True,  True,  True]).all
 +      where array([ True,  True, False, False, False, False, False, False, False,\n       False, False,  True,  True,  True, False,... True, False, False, False, False, False, False, False,  True,\n        True, False,  True, False,  True,  True,  True]) = <function isclose at 0x7fa1ac1bbdb0>(array([88.98678307, 89.01165005, 88.97841268, 88.96751401, 89.09010656,\n       88.90566361, 89.0809015 , 88.97877542, ... 89.53965596,\n       88.55093739, 88.44080437, 88.52033268, 89.5449282 , 88.57527244,\n       89.52097151, 88.42747565]), array([88.98678311, 89.01165012, 88.97841234, 88.96751435, 89.09010675,\n       88.90566394, 89.08090131, 88.97877564, ... 89.53965603,\n       88.55093743, 88.44080454, 88.52033267, 89.54492844, 88.57527252,\n       89.52097159, 88.42747561]), atol=1e-10, rtol=1e-09)
 +        where <function isclose at 0x7fa1ac1bbdb0> = np.isclose
===== 11 failed, 543 passed, 82 skipped, 27 warnings in 269.56s (0:04:29) ======

[mairanteodoro]

Hi, Brett! Those unit tests are failing because the VO API from which we fetch Gaia data has been updated. As of today, the "epoch" parameter passed in the call to the API will return coordinates that have been corrected for proper motion and parallax (whenever available). Our unit tests only account for proper motion, the standard API behavior until now. I will update the unit tests. Thanks!

[braingram]

Thanks!

[braingram]

@mairanteodoro is there any documentation for the service used to fetch the catalogs?

Going to the main url https://gsss.stsci.edu/ yields a message posted in 2010

Our website and webservices has been moved to a new system. Please contact us if you find any broken links or services.

[braingram]

I believe this was fixed in: #919