Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update webbpsf for compatibility with photutils 2.0 #924

Open
mperrin opened this issue Oct 30, 2024 · 2 comments · May be fixed by #925
Open

update webbpsf for compatibility with photutils 2.0 #924

mperrin opened this issue Oct 30, 2024 · 2 comments · May be fixed by #925
Assignees
Labels
bug Something isn't working

Comments

@mperrin
Copy link
Collaborator

mperrin commented Oct 30, 2024

Something in the just-released photutils 2.0 seems to have changed such that test which used to pass for webbpsf are now failing. See for instance https://github.com/spacetelescope/webbpsf/actions/runs/11598524893/job/32294569438?pr=923

@larrybradley might you have any quick suggestions on what we could look into for this?

@larrybradley
Copy link
Member

@mperrin Yes, GriddedPSFModel uses an bicubic interpolator (RectBivariateSpline) to evaluate the model. This requires at least 4 points in both x and y, hence the minimum PSF size is 4x4 pixels. Previously, if one initialized a GriddedPSFModel with a PSF size smaller than 4x4 pixels, one would get a cryptic error from scipy when trying to evaluate the model. In photutils 2.0, I added a check for this that raises an informative error message when the model is initialized (that you are seeing in your test failure):
ValueError: The length of the PSF x and y axes must both be at least 4.

@mperrin
Copy link
Collaborator Author

mperrin commented Oct 30, 2024

Aha thanks. So my trick in some CI test function to make some with 1x1 size to speed runtime doesn’t work anymore! Got it. Will make that test case use 4x4.

@mperrin mperrin linked a pull request Oct 30, 2024 that will close this issue
@mperrin mperrin self-assigned this Oct 31, 2024
@mperrin mperrin added the bug Something isn't working label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants