Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Sampling #59

Closed
ckoch-cars opened this issue Mar 15, 2023 · 1 comment
Closed

Implement Sampling #59

ckoch-cars opened this issue Mar 15, 2023 · 1 comment

Comments

@ckoch-cars
Copy link

According to a conversation with Datadog, the Datadog agent does not down-sample itself, but expects the traces to be flagged, via :priority, to either keep or drop. Also, DD intends to charge for trace volume.

Would you consider a PR to implement this in this package? Possibly using an application env var?
@ckoch-cars
Copy link
Author

Upon further review, sampling at the end of the process would be suboptimal. Distributed traces would not be consistently sampled the same way.
See a PR from my colleague for head-based sampling, which is what Datadog recommends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ckoch-cars