Add support for country regions #14
Replies: 3 comments 4 replies
-
|
#12 made an attempt towards supporting region, feedback appreciated |
Beta Was this translation helpful? Give feedback.
-
|
Suggest to use ISO Standard for states. |
Beta Was this translation helpful? Give feedback.
-
|
I added state support and added States for Germany and Austria. #37 |
Beta Was this translation helpful? Give feedback.
-
|
We've added documentation on how we would implement regions, states, departments, ... |
Beta Was this translation helpful? Give feedback.
-
|
As described in the PR #37 this implementation is not suitable for every use-case. Example: Spain has national holidays, regional holidays, state holidays, etc... Commonly, holidays for those regions are listed separately in calendars for example. But when trying to know if a certain day is a holiday, every layer of regions get's checked. Having this in mind, I don't see a nice way to obtain all that information in the currently proposed way. There are some good alternative ways to get that done: Those proposals are not perfect either, but with a bit of tinkering we could get good results. I, and I think a lot of other people would be very open to tinker on this, but my PR hasn't gotten a reply since you asking for our opinion on that. If no alternative solution is wanted, you can close my PR. I know that this package is not your main focus and I am very grateful for this package attempt and all your other packages. But this one-sided communication is very frustrating. Nobody adopted this implementation yet because there are too many open questions. |
Beta Was this translation helpful? Give feedback.
-
|
@marlonbasten, I appreciate your engagement and the time you've invested. Please bear in mind, this package has received over 160 PR in less than a week. As an open-source maintainer, my (free) time is limited, and I don’t feel I need to rush here. I've considered your suggestions and discussed this with my open source experienced colleagues. We believe that a more effective approach for maintaining regions in this package is already described in the README. But I’ve already communicated this on your PR in an early phase. |
Beta Was this translation helpful? Give feedback.
-
|
Hey @Nielsvanpach i have tried to follow the README and created a small proof of concept implementing regional support: #173 However i was not able to use named parameters with Maybe you can give me some feedback on how you like it? |
Beta Was this translation helpful? Give feedback.
-
As stated in #8 and #12 , countries can have region bound holidays.
Beta Was this translation helpful? Give feedback.
All reactions