Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make json and tag-value writer more consistent #402

Closed
armintaenzertng opened this issue Jan 3, 2023 · 2 comments
Closed

Make json and tag-value writer more consistent #402

armintaenzertng opened this issue Jan 3, 2023 · 2 comments
Labels
writer Issues concerning the writing layer

Comments

@armintaenzertng
Copy link
Collaborator

The two writers have been written by two different persons, thus sharing some common code which can be extracted and sporting slightly different API, which can be unified.
@meretp meretp mentioned this issue Jan 9, 2023
Closed
@meretp
Copy link
Collaborator

meretp commented Jan 9, 2023

Additionally the json/yaml/xml writers optionally validate the given file whereas the tag-value writer writes the document without validation.

@meretp meretp added the writer Issues concerning the writing layer label Jan 11, 2023
@meretp meretp mentioned this issue Mar 28, 2023
Merged
@armintaenzertng armintaenzertng mentioned this issue Apr 12, 2023
Merged
@armintaenzertng
Copy link
Collaborator Author

All writers are now consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
writer Issues concerning the writing layer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@meretp @armintaenzertng