Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPE-3377] Feature: Duplicate entries in package.json #644

Open
lucassimao opened this issue Apr 19, 2024 · 2 comments
Open

[SPE-3377] Feature: Duplicate entries in package.json #644

lucassimao opened this issue Apr 19, 2024 · 2 comments
Assignees
Labels
High priority Created by Linear-GitHub Sync linear
Milestone

Comments

@lucassimao
Copy link

lucassimao commented Apr 19, 2024

I'm adding a custom script to my final package.json file by doing the following in the .speakeasy/gen.yaml file:

image

Unfortunately for the preinstall script, I'm ending up with two scripts properties in my package.json file:

image

am I using additionalPackageJSON wrongly or is it a bug?

From SyncLinear.com | SPE-3377

@AshGodfrey AshGodfrey self-assigned this Apr 19, 2024
@AshGodfrey
Copy link
Contributor

Hey @lucassimao - additionalPackageJSON is meant to add additional properties into the package.json file, rather than augment ones that Speakeasy generates.

That said this has been noted as feature request, thank you!

@simplesagar simplesagar changed the title Duplicate entries in package.json [SPE-3377] Duplicate entries in package.json May 13, 2024
@simplesagar simplesagar added the Medium priority Created by Linear-GitHub Sync label May 13, 2024
@simplesagar simplesagar changed the title [SPE-3377] Duplicate entries in package.json [SPE-3377] Feature: Duplicate entries in package.json May 16, 2024
@simplesagar simplesagar added this to the v.99 milestone May 16, 2024
@simplesagar simplesagar modified the milestones: v.99, v.100 May 22, 2024
@simplesagar simplesagar modified the milestones: v.100, v.101, v.102 May 29, 2024
@simplesagar simplesagar modified the milestones: v.102, v.103 Jun 12, 2024
@simplesagar simplesagar modified the milestones: v.103, v.104, v.105 Jun 19, 2024
@simplesagar simplesagar modified the milestones: v.105, v.106 Jul 3, 2024
@simplesagar simplesagar modified the milestones: v.106, v.107, v.108 Jul 10, 2024
@simplesagar simplesagar modified the milestones: v.108, v.109 Jul 24, 2024
@simplesagar simplesagar modified the milestones: v.112, v.113 Aug 14, 2024
@simplesagar simplesagar modified the milestones: v.113, v.114 Aug 28, 2024
@simplesagar simplesagar modified the milestones: v.114, v.115, v.116 Sep 4, 2024
@simplesagar simplesagar modified the milestones: v.116, v.117 Sep 18, 2024
@simplesagar simplesagar added High priority Created by Linear-GitHub Sync and removed Medium priority Created by Linear-GitHub Sync labels Sep 23, 2024
@ThomasRooney
Copy link
Member

Bumped as a few other customers ran into this, and it's semi-trivial to fix

@simplesagar simplesagar modified the milestones: v.117, v.118, v.119 Sep 25, 2024
@simplesagar simplesagar modified the milestones: v.119, v.120, v.121 Oct 9, 2024
@simplesagar simplesagar modified the milestones: v.121, v.122 Oct 22, 2024
@simplesagar simplesagar modified the milestones: v.122, v.123, v.124 Oct 30, 2024
@simplesagar simplesagar modified the milestones: v.124, v.125 Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High priority Created by Linear-GitHub Sync linear
Projects
None yet
Development

No branches or pull requests

4 participants