Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloaded files being duplicated #2638

Closed
melton-jason opened this issue Dec 13, 2022 · 6 comments · Fixed by #4404
Closed

Downloaded files being duplicated #2638

melton-jason opened this issue Dec 13, 2022 · 6 comments · Fixed by #4404
Assignees
Labels
1 - Bug Incorrect behavior of the product

Comments

@melton-jason
Copy link
Contributor

melton-jason commented Dec 13, 2022

Describe the bug
Whenever a file is downloaded (whether through error dialog, app resources, etc.), Specify seems to download an additional copy of the file, resulting in two files being downloaded when only one is expected.

Most likely same cause as #2288

Only seems to occur on testability. Does not occur on edge.

Unlike in #2288. downloads from App Resources are not being duplicated in versions 7.7.5 or earlier.

Tested in a local instance of Specify 7 and on databases:
coldfish
willemcatno

Environment Info
OS: Windows 11
Browser: Chrome

CARLOS EDIT
After further investigation, it appears that this issue exclusively affects Chrome and Safari. It possibly affects other browsers too. However, in Firefox, downloads work just fine.

@melton-jason melton-jason added 1 - Bug Incorrect behavior of the product pri:unknown labels Dec 13, 2022
@melton-jason
Copy link
Contributor Author

Interestingly, the Exception file download for when updating RSS Feed fails only downloads once.
(On a related note, the file name for this should be improved. It currently is download.txt)

@maxpatiiuk
Copy link
Member

For more information, see also #2288

@grantfitzsimmons
Copy link
Member

Reported By: Heather Cole at AAFC

@grantfitzsimmons
Copy link
Member

Fixed in v7.9

@carlosmbe
Copy link
Contributor

carlosmbe commented Jul 11, 2023

Tested Stats Page's Download as TSV. Fixed in Firefox. Duplicate Downloads still Present in Chrome.

Chrome

Screen.Recording.2023-07-11.at.12.31.50.PM.mov

Firefox

Screen.Recording.2023-07-11.at.12.32.42.PM.mov

@carlosmbe carlosmbe reopened this Jul 11, 2023
@carlosmbe carlosmbe changed the title Downloaded files being duplicated Stats Page Downloaded TSV files being duplicated Jul 11, 2023
@maxpatiiuk
Copy link
Member

From @carlosmbe:

Describe the bug
Title. When I download the TSV of stats page

To Reproduce
Steps to reproduce the behavior:

  1. Go to Stats Page
  2. Click on Download as TSV
  3. See error

Expected behavior
Download only one copy.
Theoretically speaking this should be easy as we made a PR addressing this issue around the 7.8.8 -> 7.8.13 era

Beautiful Screen Recording

Screen.Recording.2023-10-16.at.9.36.26.PM.mov

Desktop:

  • OS: Mac Os X
  • Browser: Chrome
  • Specify 7 Version: 7.9

@carlosmbe carlosmbe changed the title Stats Page Downloaded TSV files being duplicated Downloaded files being duplicated Dec 5, 2023
@bronwyncombs bronwyncombs added this to the Grant's issue list milestone Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Bug Incorrect behavior of the product
Projects
Status: Done
Status: Shipped
Development

Successfully merging a pull request may close this issue.

5 participants