Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if trampoline is used, prioritize mpp_splits that use the same trampoline #7087

Open
ecdsa opened this issue Mar 6, 2021 · 2 comments
Open

Comments

@ecdsa
Copy link
Member

ecdsa commented Mar 6, 2021

If trampoline is used, mpp_split should prioritize solutions that send HTLCs to the same trampoline.
This will reduce fees, and also reduce the probability of failure.

@ecdsa
Copy link
Member Author

ecdsa commented Mar 6, 2021

@bitromortac

@bitromortac
Copy link
Contributor

The issue with payment indexing was fixed in eclair, see ACINQ/eclair#1723.

electrum/electrum/lnworker.py

Lines 1526 to 1530 in 9c1a515

# for trampoline mpp payments we have to restrict ourselves to pay
# to a single node due to some incompatibility in Eclair, see:
# https://github.com/ACINQ/eclair/issues/1723
use_singe_node = not self.channel_db and constants.net is constants.BitcoinMainnet
split_configurations = suggest_splits(amount_msat, channels_with_funds, single_node=use_singe_node)

This should be no longer relevant and we could test sending via different trampoline nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants