Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 2023 year in testdata #64

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump to 2023 year in testdata #64

wants to merge 1 commit into from

Conversation

ivankovnatsky
Copy link

Close #63.

@CLAassistant
Copy link

CLAassistant commented Jan 20, 2023

CLA assistant check
All committers have signed the CLA.

@marckhouzam
Copy link
Collaborator

CI is failing fort other reasons. Sigh...
We'll need to clean this up.

@viraptor
Copy link

viraptor commented Feb 5, 2023

Can this be fixed permanently with Replace of current year to "{current_year}" on both sides before comparison? The periodic fixes are problematic for distros which run tests when building the package.
For example I'm disabling the tests in Nixpkgs, because the build starts failing even though the software doesn't change https://hydra.nixos.org/build/207401170/nixlog/2
NixOS/nixpkgs#214715

@marckhouzam
Copy link
Collaborator

Can this be fixed permanently with Replace of current year to "{current_year}" on both sides before comparison? The periodic fixes are problematic for distros which run tests when building the package.

I agree we need a better approach. However allowing the tests to pass would prevent user from remembering these files need to be changed. But I haven't looked at the code in a while so I might be missing something.

@vcunat
Copy link

vcunat commented Feb 18, 2023

Such a failure sounds suitable for your CI (upstream), but I think basically anyone else will be unhappy with that breakage. There are situations when even older versions are desirable to use (e.g. bisecting regressions across history) and then similar newly-appearing failures can be annoying.

@ivankovnatsky ivankovnatsky closed this by deleting the head repository Mar 2, 2023
@ivankovnatsky
Copy link
Author

Damn it, I was cleaning up some public forked repos.

@ivankovnatsky ivankovnatsky reopened this Mar 21, 2023
@github-actions
Copy link

This PR is being marked as stale due to a long period of inactivity

Copy link
Collaborator

@jpmcb jpmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship this, get tests passing, and open a new issue to revisit this.

I just ran into this as well and it's annoying to have test flakes while working on other things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests broken in 2023
6 participants