Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sphinx 7.4.0 breaks parsing of MyST-Parser (and probably others) configuration in conf.py #12582

Closed
jfbu opened this issue Jul 15, 2024 · 4 comments · Fixed by #12584
Closed
Labels
Milestone

Comments

@jfbu
Copy link
Contributor

jfbu commented Jul 15, 2024

Describe the bug

Bad output:
Capture d’écran 2024-07-15 à 12 11 14

Good output:
Capture d’écran 2024-07-15 à 12 10 44

How to Reproduce

conf.py:

extensions = ['myst_parser',
]

myst_enable_extensions = ["colon_fence"]
source_suffix = ['.rst', '.md']

index.md:

# La FAQ LaTeX francophone !


:::{only} html
Hello
:::

## Section

:::{admonition} Here's my title
:class: tip

Here's my admonition content.
:::

Environment Information

Git bisect blames 82edc3d

Running Sphinx v7.4.0+/82edc3d38
Sphinx version: 7.4.0+/82edc3d38
Python version: 3.12.3 (CPython)
Docutils version: 0.20.1 
Pygments version: 2.18.0
Jinja2 version: 3.1.4
MyST-parser version: 3.0.1

Sphinx extensions

extensions = ['myst_parser',
]

myst_enable_extensions = ["colon_fence"]
source_suffix = ['.rst', '.md']
@jfbu
Copy link
Contributor Author

jfbu commented Jul 15, 2024

I am sorry I did not catch that, but right prior to 7.4.0 release I was on my PR #12508 branch all of the time and did use it on big project regularly until a few days ago and clearly the branch was without the bad commit. Perhaps at very end it did after I had done one or two merges of master (I have not checked that, speaking hypothetically) but at this stage (last two days circa) I was only compiling via latexpdf some small testing project for finalizing admonition styles and was not using Markdown/MyST-Parser for input.

@AA-Turner
Copy link
Member

Your source_suffix should ideally be:

source_suffix = {
    '.rst': 'restructuredtext',
    '.md': 'markdown',
}

However the list-style has not yet been fully deprecated and removed, so I will restore support.

@jfbu
Copy link
Contributor Author

jfbu commented Jul 15, 2024

@AA-Turner Indeed! I fetched that config from the big project where the problem was first detected! Issue is much less serious I first thought then...

@AA-Turner
Copy link
Member

Sphinx 7.4.3 has been released with a fix.

A

@AA-Turner AA-Turner added this to the 7.4.x milestone Jul 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants