Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3RepositoryBackend: Do not explicitly check existence of objects before deleting #21

Open
sphuber opened this issue Feb 27, 2023 · 0 comments

Comments

@sphuber
Copy link
Owner

sphuber commented Feb 27, 2023

See #20 for a discussion. The current implementation calls the super, which performs a preliminary check using has_objects, which in turn calls list_objects which will be very expensive for larger repositories. If the interface of the AbstractRepositoryBackend allows it, we should simply call boto3.delete_objects which will delete all files that exist and return an error for keys that didn't exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant