Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: global update #19

Closed
wants to merge 8 commits into from
Closed

feat: global update #19

wants to merge 8 commits into from

Conversation

SunsetTechuila
Copy link
Contributor

@SunsetTechuila SunsetTechuila commented Dec 1, 2023

resolves #4

packages for testing: create-spicetify-app, spicetify-creator

Changelog

General:

  • bumped dependencies
  • switched from yarn to pnpm
  • added prettier
  • made both packages pure es modules
  • refactored, optimized a little bit and cleaned up the code

Spicetify Creator:

  • improved monorepos support
  • switched from uglify-js & clean-css to esbuild for css/js minification
  • switched from esbuild-plugin-postcss2 to esbuild-style-plugin
  • updated types to account custom apps name localization
  • added esbuild-plugin-inline-import

Create Spicetify app

  • added pnpm support
  • set react types version to 17.0.2 (used in Spotify v1.2.0-1.2.26)
  • updated the template's tsconfig.json
  • added update:spicetify-types npm script to the template package.json
  • renamed build-local script to build
  • renamed build script to build:local
  • updated templates code

BREAKING CHANGE

Since esbuild-plugin-postcss2 has been replaced with esbuild-style-plugin all style imports need to be updated to use relative paths, otherwise you will get an error like this [plugin esbuild-style-plugin] Could not resolve "css/app.module.scss" during the compilation

@SunsetTechuila SunsetTechuila marked this pull request as draft December 5, 2023 14:50
@SunsetTechuila SunsetTechuila marked this pull request as draft December 5, 2023 14:50
@SunsetTechuila SunsetTechuila marked this pull request as ready for review January 20, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change from "esbuild-plugin-postcss2"
1 participant