Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Color Not Adapting to High Contrast Backgrounds in StarryNight/Base Theme #1109

Open
violetto-rose opened this issue Aug 31, 2024 · 4 comments · May be fixed by #1112
Open

Font Color Not Adapting to High Contrast Backgrounds in StarryNight/Base Theme #1109

violetto-rose opened this issue Aug 31, 2024 · 4 comments · May be fixed by #1112

Comments

@violetto-rose
Copy link

I'm experiencing an issue where the font color doesn't adjust properly when using the StarryNight or Base theme in Spicetify. Specifically, when the background changes based on album artwork, the font color remains the same, even with high contrast backgrounds, making the text difficult to read.

Steps to Reproduce:

Use the StarryNight or Base theme in Spicetify.
Play music with album artwork that has a light or dark background.
Observe that the font color does not change to adapt to the background, leading to low readability.

Expected Behavior: The font color should automatically adjust to provide sufficient contrast with the background, ensuring the text remains readable regardless of the album artwork colors.

Screenshots:
Screenshot 2024-09-01 044640
Screenshot 2024-09-01 044705
Screenshot 2024-09-01 044718

Specifics
OS: Windows 11 Home Single Language

  • Spotify for Windows (64-bit) 1.2.45.454.gc16ec9f6
  • Spicetify v2.37.7
  • Theme: StarryNight Night/ Base
@b-chen00
Copy link
Contributor

b-chen00 commented Sep 5, 2024

The StarryNight theme doesn't change the background or font color based on the album artwork. When using the base color scheme, the background should always be a dark blue color with white text as shown below rather than what the album artwork is. What extensions, snippets, or apps are you using that could potentially affect this?
image

@b-chen00
Copy link
Contributor

Nevermind, I see a problem
image

@violetto-rose
Copy link
Author

Oh sorry, I didn't see your mails.
Also, the extensions I'm using currently are attached below.
I tried using custom CSS from ChatGPT using CSS Editor with the code attached below, which of course didn't work.
Screenshot 2024-09-22 154922
Screenshot 2024-09-22 154934
Screenshot 2024-09-22 154951
Screenshot 2024-09-22 155302

@b-chen00
Copy link
Contributor

Waiting for the pull request to be merged (see linked pull request above). Should fix visibility issues though let me know if it doesn't once the changes make its way through

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants