Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bool checks #466

Open
kfox1111 opened this issue Sep 20, 2024 · 0 comments
Open

bool checks #466

kfox1111 opened this issue Sep 20, 2024 · 0 comments

Comments

@kfox1111
Copy link
Collaborator

We have some bools in the templates get checked against string values as well. EX:

        {{- if eq (.Values.notifier.k8sbundle.enabled | toString) "true" }}

rather then just:

        {{- if .Values.notifier.k8sbundle.enabled }}

This complicates the code. We should use the schema support we added to ensure the bools are bools and we can then remove all the string checks on the bools from the templates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant