Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: field extraction error message #448

Merged
merged 1 commit into from
Nov 10, 2021
Merged

fix: field extraction error message #448

merged 1 commit into from
Nov 10, 2021

Conversation

nandinivij
Copy link
Contributor

@nandinivij nandinivij commented Nov 9, 2021 •
edited
Loading

Please review
Changed the field messaging format to display errors as -

Field extraction errors: {
E             "Key value in requirement file: action": "create",
E             "Key value extracted by Splunk: action": "created",
E             "Key value in requirement file: change_type": "filesyste",
E             "Key value extracted by Splunk: change_type": "filesystem"
E         }

@nandinivij nandinivij force-pushed the requirement_test/error_message branch from 1346a70 to 21c03da Compare November 9, 2021 21:38
ghost
ghost reviewed Nov 9, 2021
View reviewed changes
pytest_splunk_addon/standard_lib/requirement_tests/test_templates.py Outdated

assert datamodel_check and field_extraction_check, (
f" Issue with either field extraction or data model.\nsearch={search}\n"
f" data model check: {datamodel_check} \n"
f" data model in requirement file {model_datalist}\n "
f" data model extracted by TA {list(datamodel_based_on_tag.keys())}\n"
f" Field_extraction_check: {field_extraction_check} \n"
f" Key value not extracted by TA: {missing_key_value} \n"
f" Mismatched key value: {mismapped_key_value_pair}\n"
f" Field extraction errors: {json.dumps(missing_key_value, indent=4)}q \n"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "q" in the end

@nandinivij nandinivij force-pushed the requirement_test/error_message branch from 21c03da to 3b24a1f Compare November 9, 2021 21:46
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2021 •
edited by nandinivij
Loading

Expected release notes (by @nandinivij)

fixes:
field extraction error message (3b24a1f)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

drnkllr
drnkllr approved these changes Nov 10, 2021
View reviewed changes
Copy link

@drnkllr drnkllr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nandinivij nandinivij merged commit 2451d40 into main Nov 10, 2021
@nandinivij nandinivij deleted the requirement_test/error_message branch November 10, 2021 16:33
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2021
@ryanfaircloth
Copy link
Contributor

🎉 This PR is included in version 1.10.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@drnkllr drnkllr drnkllr approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nandinivij @ryanfaircloth @drnkllr