Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add test name in test_string #517

Merged
merged 2 commits into from
Jan 25, 2022
Merged

feat: add test name in test_string #517

merged 2 commits into from
Jan 25, 2022

Conversation

nandinivij
Copy link
Contributor

@nandinivij nandinivij commented Jan 21, 2022 •
edited
Loading

Add test_name to test string to make it easier to find event in xml by name than by index.

@nandinivij nandinivij marked this pull request as ready for review January 21, 2022 19:32
@nandinivij nandinivij requested review from a user and kkania-splunk January 21, 2022 19:32
@nandinivij
feat: Add test name in test_string
bd3774f 
pytest.expect files containing requirement tests needs update
ghost
ghost suggested changes Jan 24, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit is failing, please fix.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2022 •
edited by nandinivij
Loading

Expected release notes (by @nandinivij)

features:
Add test name in test_string pytest.expect files containing requirement tests needs update (bd3774f)

fixes:
pre-commit failures (f180337)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@nandinivij nandinivij requested a review from a user January 25, 2022 04:56
@nandinivij nandinivij merged commit db3ed4f into main Jan 25, 2022
@nandinivij nandinivij deleted the feat/ADDON-46856 branch January 25, 2022 16:10
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2022
@srv-rr-github-token
Copy link
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kkania-splunk kkania-splunk Awaiting requested review from kkania-splunk

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nandinivij @srv-rr-github-token