Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large int64 values are truncated #39

Closed
yesthatguy opened this issue Oct 29, 2020 · 2 comments
Closed

Large int64 values are truncated #39

yesthatguy opened this issue Oct 29, 2020 · 2 comments

Comments

@yesthatguy
Copy link

I have a locationId field in my proto which is a fixed64 type, and am trying to request location ID 1234577704719498930

The server is instead receiving a request for location ID 1234577704719499008

Having run into this with some web frontends, my best guess is that Protoman is using a javascript Number internally, which only supports 53 bits, so it's truncating the integer input. This can probably be fixed by using BigInt instead of Number.

@pandawithcat
Copy link
Collaborator

thanks for the feedback. I've been MIA for a while but now i'm back on track so i'll try to resolve most of the issues soon!

@DonghunLouisLee DonghunLouisLee added this to the v0.5.0 milestone Jul 28, 2021
@DonghunLouisLee
Copy link
Collaborator

@yesthatguy fixed64 is an ongoing issue for protobuf.js(protobufjs/protobuf.js#1557) and since protoman relies on protobuf.js, this issue will be handled when protobuf.js is handled!

@DonghunLouisLee DonghunLouisLee removed this from the v0.5.0 milestone Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants