Issue when upgrading luigi version #2017
Comments
|
Oh, that's bad. Can @nmb10 take a look? I guess we should make so travis tests that the |
|
Hi, @Tarrasch . Will check that today. |
|
Can't reproduce. @dlstadther what is your environment? (OS, python). My try with latest luigi (commit = d21906, 'Fix required credential...'), fresh virtual env, debian 8, python 2.7.9 |
|
|
Long story short, it must be something messed up with my virtualenv. I can only recreate this issue in that specific venv. If i create relative copies and install luigi 2.3.3 and then bleeding-edge, it's fine. So i just need to recreate a fresh venv. sorry for the firedrill |
|
We hit this same issue today just doing a |
|
output: |
|
Hi, @louissalin . Maybe it's cache issue? |
|
I'll have to check. I just reran the command to show the output, so it makes sense that it used the cache on the 2nd run. This issue happened 16 hours after luigi 2.6.0 was released while we were building our docker containers (python 3.5 on Centos7). It's highly unlikely we already had downloaded luigi 2.6.0. After noticing our containers weren't building, we tried it on our macs and got the same issue. |
|
I'm having the same issue (can't copy 'luigi/static/visualiser/lib/URI.js') using: |
|
I'm having the same issue (can't copy 'luigi/static/visualiser/lib/URI.js') using: |
|
I'm also hitting this issue with 2.6.0. It appears to be related to this line in the setup.py that declares all EDIT: I think this is the same issue as in #2027 #2028 #2029 |
|
@anjackson I wonder why all the linked issues are closed. |
|
@louissalin the linked issues are closed as they're dups of this one. I closed this issue b/c I was unable to recreate the issue from a fresh install or a fresh upgrade. |
|
Hi @dlstadther, I just recreated the issue in a docker container running Centos 7 using python 3.5 and pip 9.0.1: |
|
It works fine with the official python 3.5 and 3.6 docker images. This is the output I got from running it inside the python:3.6 container. |
|
@dlstadther: I think I found a way for you to reproduce the issue. You will need docker to be able to run the following steps in the exact same environment. This time, it's using python 2.7 and pip 8.1.2. It looks like this may be an OS specific issue. I tried to install luigi in all the official OSes that python comes bundled in from the docker hub and it worked on all of them. |
|
Hi, @louissalin . I can reproduce it now, thanks. Trying to solve. |
|
It seems pip considers URI.js directory as file and tryes to copy it. After dropping '.js' luigi installed without error. $ mv luigi/static/visualiser/lib/URI.js/ luigi/static/visualiser/lib/URINote that after rename one should fix URI.js url in the luigi/static/visualiser/index.htmlI think simplest and most safe fix is to rename URI.js directory. I'm going to implement that if there are no better ideas. |
|
Hi, @dlstadther . I think we should keep version number. Otherwise it may be hard to find version and may cause cache issues in the future. |
|
@nmb10 I have no problem with either solution. Wait...question.... if |
|
I don't believe a directory of |
|
@FlorianLudwig it could, but #2033 was just merged and should resolve this issue. |
|
@dlstadther yeah, noticed it shortly after writing my question and deleted the comment :) |
|
Just as an update, Kazbek's solution of...
"$ mv luigi/static/visualiser/lib/URI.js/ luigi/static/visualiser/lib/URI"
...worked beautifully for me. In fact, when I checked the install after
... the URI.js still get's put in place properly, so I didn't even need
to use his suggestion of altering the HTML files.
…--
*Michael Rightmire*
B.Sci. Molecular Biotechnology
MCSE,MCP+I,HPUXCA,CompTIA,VDE, SIAM,ISCB
Skype:RightmireM
+49-721-1320-2562 (DE)
+1-408-890-2121 (USA)
Biocom Biotechnology and Software
BiocomSoftware.Com <Http://biocomsoftware.com>
BiocomSoftware.De <http://Biocomsoftware.de>
//
The contents of this email message and any attachments are intended
solely for the addressee(s) and may contain confidential and/or
privileged information and may be legally protected from disclosure. If
you are not the intended recipient of this message or their agent, or if
this message has been addressed to you in error, please immediately
alert the sender by reply email and then delete this message and any
attachments. If you are not the intended recipient, you are hereby
notified that any use, dissemination, copying, or storage of this
message or its attachments is strictly prohibited.
|
|
The luigi 2.6.0 from pip still does not work as I think there has not been a new release. Any plans for releasing 2.6.1 with this fix? |
|
I think this is related If this would be fixed by moving python code to python 3 let me know. |
Closed
|
The only way I have been able to get a working luigi environment is to install the bleeding edge via: pip install git+https://github.com/spotify/luigi.git Definitely would be nice if there was update on PyPi. |
|
See 2.6.1 for PyPi release including this bug fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When upgrading to a version of luigi at or after 6e549ef, I receive the following when
python setup.py installwithin an existing venv.This commit added a file
luigi/static/visualiser/lib/URI.js/1.18.2/URI.js. I'm suspicious there's a problem here.The text was updated successfully, but these errors were encountered: