Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaged sbt.compat not compatible with sbt-compat plugin #79

Closed
oleastre opened this issue Oct 20, 2017 · 4 comments
Closed

Packaged sbt.compat not compatible with sbt-compat plugin #79

oleastre opened this issue Oct 20, 2017 · 4 comments

Comments

@oleastre
Copy link

oleastre commented Oct 20, 2017

I cannot use sbt-revolver 0.9.0 with the latest ensime-sbt plugin ( same problem as https://github.com/ensime/ensime-sbt/issues/369 ).
sbt-ensime uses the sbt-compat plugin that packages it's objects in sbt.compat.
The latest jar of sbt-revolver also includes objects under the sbt/compta path that causes class loading issues.

Rebuilding the current sbt-revolver and testing with sbt publishLocal solves the problem. So I suppose it's some release/packaging problem.

@jrudolph
Copy link
Member

Thanks for the report. Yes, makes sense to move the package to get rid of these kinds of problems.

@jrudolph
Copy link
Member

Indeed, we just stumbled over the same issues ourselves (this time in combination with sbt-dependency-graph). It took a while until I remembered this issue. Great, you already figured out that it was related to those classes in the jar which shouldn't have been there. That was really unexpected.

I released v0.9.1 cleanly which should fix the issue.

@oleastre
Copy link
Author

Thanks for that.
Maybe using sbt-release for the release process should be a good option to avoid that kind of error. It ensure your git repository does not contain modifications and it starts the release with a "clean" command ;-)

@jrudolph
Copy link
Member

Yeah, that's right. Every automated process would be good I guess. At some point we'll get to that ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants