Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release main #629

Merged
merged 1 commit into from
Sep 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .release-please-manifest.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"packages/ui5-cc-spreadsheetimporter": "1.2.2",
"packages/ui5-cc-spreadsheetimporter": "1.3.0",
"packages/ui5-cc-spreadsheetimporter-generator": "0.6.0"
}
10 changes: 5 additions & 5 deletions docs/pages/Button.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,12 @@ npm install ui5-cc-spreadsheetimporter
⚠️ You must always keep your `ui5-cc-spreadsheetimporter` and button version up to date here when updating the module.

!!! warning ""
⚠️ The `resourceRoots` path "./thirdparty/customcontrol/spreadsheetimporter/v1_2_2" changed from version 0.34.0 to lowercase. Please make sure to use the correct path.
⚠️ The `resourceRoots` path "./thirdparty/customcontrol/spreadsheetimporter/v1_3_0" changed from version 0.34.0 to lowercase. Please make sure to use the correct path.


```json
"resourceRoots": {
"cc.spreadsheetimporter.v1_2_2": "./thirdparty/customcontrol/spreadsheetimporter/v1_2_2"
"cc.spreadsheetimporter.v1_3_0": "./thirdparty/customcontrol/spreadsheetimporter/v1_3_0"
}
```

Expand All @@ -52,7 +52,7 @@ npm install ui5-cc-spreadsheetimporter
"sap.ui.table": {}
},
"components": {
"cc.spreadsheetimporter.v1_2_2": {}
"cc.spreadsheetimporter.v1_3_0": {}
}
}
```
Expand All @@ -64,7 +64,7 @@ npm install ui5-cc-spreadsheetimporter
```json
"componentUsages": {
"spreadsheetImporter": {
"name": "cc.spreadsheetimporter.v1_2_2"
"name": "cc.spreadsheetimporter.v1_3_0"
}
}
```
Expand Down Expand Up @@ -134,7 +134,7 @@ A sample configuration can be found in the manifest.json of the [OData V4 Fiori
"customSectionReuse": {
"title": "Spreadsheet Upload",
"embeddedComponent": {
"name": "cc.spreadsheetimporter.v1_2_2",
"name": "cc.spreadsheetimporter.v1_3_0",
"settings": {
"tableId": "ui.v4.ordersv4fe::OrdersObjectPage--fe::table::Items::LineItem-innerTable"
}
Expand Down
12 changes: 12 additions & 0 deletions docs/pages/CHANGELOGSPREADSHEETIMPORTER.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,17 @@
# Changelog

## [1.3.0](https://github.com/spreadsheetimporter/ui5-cc-spreadsheetimporter/compare/ui5-cc-spreadsheetimporter-v1.2.2...ui5-cc-spreadsheetimporter-v1.3.0) (2024-09-16)


### Features

* new parameter `bindingCustom` ([#628](https://github.com/spreadsheetimporter/ui5-cc-spreadsheetimporter/issues/628)) ([935ea47](https://github.com/spreadsheetimporter/ui5-cc-spreadsheetimporter/commit/935ea47628d098fe45f024f96e85111149a10694))


### Bug Fixes

* in V4 context check if it is possible to execute with `editFlow` ([#630](https://github.com/spreadsheetimporter/ui5-cc-spreadsheetimporter/issues/630)) ([c5701a9](https://github.com/spreadsheetimporter/ui5-cc-spreadsheetimporter/commit/c5701a918cfc1bb111c1e9b7d4002f4a92031f74))

## [1.2.2](https://github.com/spreadsheetimporter/ui5-cc-spreadsheetimporter/compare/ui5-cc-spreadsheetimporter-v1.2.1...ui5-cc-spreadsheetimporter-v1.2.2) (2024-09-10)


Expand Down
12 changes: 6 additions & 6 deletions docs/pages/CentralDeployment.md
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ npm install ui5-middleware-servestatic --save-dev
```yml
- name: ui5-middleware-servestatic
afterMiddleware: compression
mountPath: /resources/cc/spreadsheetimporter/v1_2_2/
mountPath: /resources/cc/spreadsheetimporter/v1_3_0/
configuration:
rootPath: "node_modules/ui5-cc-spreadsheetimporter/dist"
```
Expand All @@ -145,7 +145,7 @@ After you have deployed the component centrally, you can consume it in your app

To find out which URL to enter, the App Index can be called up at the following URL:
```
<SAP SYSTEM URL>/sap/bc/ui2/app_index/ui5_app_info?id=cc.spreadsheetimporter.v1_2_2
<SAP SYSTEM URL>/sap/bc/ui2/app_index/ui5_app_info?id=cc.spreadsheetimporter.v1_3_0
```

Here are the examples for [`fiori-tools-proxy`](https://www.npmjs.com/package/@sap/ux-ui5-tooling#2-proxy) and [`ui5-middleware-simpleproxy`](https://www.npmjs.com/package/ui5-middleware-simpleproxy).
Expand All @@ -160,9 +160,9 @@ Here are the examples for [`fiori-tools-proxy`](https://www.npmjs.com/package/@s
- path: /sap
url: <Cloud Connector or local URL>
destination: <System Destination name if in BAS>
- path: /resources/cc/spreadsheetimporter/v1_2_2
- path: /resources/cc/spreadsheetimporter/v1_3_0
destination: <System Destination name if in BAS>
pathPrefix: /sap/bc/ui5_ui5/sap/<BSP NAME>/thirdparty/customcontrol/spreadsheetimporter/v1_2_2/
pathPrefix: /sap/bc/ui5_ui5/sap/<BSP NAME>/thirdparty/customcontrol/spreadsheetimporter/v1_3_0/
url: <Cloud Connector or local URL>
```

Expand All @@ -171,9 +171,9 @@ Here are the examples for [`fiori-tools-proxy`](https://www.npmjs.com/package/@s
```yml
- name: ui5-middleware-simpleproxy
afterMiddleware: compression
mountPath: /resources/cc/spreadsheetimporter/v1_2_2/
mountPath: /resources/cc/spreadsheetimporter/v1_3_0/
configuration:
baseUri: "<SAP SYSTEM URL>/sap/bc/ui5_ui5/sap/<BSP NAME>/thirdparty/customcontrol/spreadsheetimporter/v1_2_2/"
baseUri: "<SAP SYSTEM URL>/sap/bc/ui5_ui5/sap/<BSP NAME>/thirdparty/customcontrol/spreadsheetimporter/v1_3_0/"
username: <SAP USERNAME>
password: <SAP PASSWORD
query:
Expand Down
20 changes: 10 additions & 10 deletions docs/pages/GettingStarted.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ To integrate the `ui5-cc-spreadsheetimporter` component manually, follow the ste

```json
"resourceRoots": {
"cc.spreadsheetimporter.v1_2_2": "./thirdparty/customcontrol/spreadsheetimporter/v1_2_2"
"cc.spreadsheetimporter.v1_3_0": "./thirdparty/customcontrol/spreadsheetimporter/v1_3_0"
}
```

Expand All @@ -60,7 +60,7 @@ To integrate the `ui5-cc-spreadsheetimporter` component manually, follow the ste
```json
"componentUsages": {
"spreadsheetImporter": {
"name": "cc.spreadsheetimporter.v1_2_2"
"name": "cc.spreadsheetimporter.v1_3_0"
}
}
```
Expand All @@ -74,7 +74,7 @@ To integrate the `ui5-cc-spreadsheetimporter` component manually, follow the ste

```json
"sap.app": {
"embeds": ["thirdparty/customcontrol/spreadsheetimporter/v1_2_2"]
"embeds": ["thirdparty/customcontrol/spreadsheetimporter/v1_3_0"]
}
```

Expand All @@ -90,7 +90,7 @@ To integrate the `ui5-cc-spreadsheetimporter` component manually, follow the ste
```json
"componentUsages": {
"spreadsheetImporter": {
"name": "cc.spreadsheetimporter.v1_2_2"
"name": "cc.spreadsheetimporter.v1_3_0"
}
}
```
Expand Down Expand Up @@ -265,7 +265,7 @@ openSpreadsheetUploadDialog: async function (oEvent) {
context: this,
},
url: "/sap/bc/ui5_ui5/sap/Z_XUP_v0_33_2",
name: "cc.spreadsheetimporter.v1_2_2"
name: "cc.spreadsheetimporter.v1_3_0"
});
this.spreadsheetUpload.openSpreadsheetUploadDialog();
this.getView().setBusy(false);
Expand All @@ -276,7 +276,7 @@ This method can be used as an alternative to `resourceRoots` in the `manifest.js

#### Error: Library/Component Used in Application Does Not Exist

When deploying the app to your ABAP system, you might encounter an error like `SAPUI5 library/component cc.spreadsheetimporter.v1_2_2 used in application Z*** does not exist`. The application is deployed, but the service returns an error.
When deploying the app to your ABAP system, you might encounter an error like `SAPUI5 library/component cc.spreadsheetimporter.v1_3_0 used in application Z*** does not exist`. The application is deployed, but the service returns an error.

To avoid this error, add the following to your `manifest.json` file:

Expand All @@ -285,7 +285,7 @@ To avoid this error, add the following to your `manifest.json` file:

```json
"sap.app": {
"embeds": ["thirdparty/customcontrol/spreadsheetimporter/v1_2_2"]
"embeds": ["thirdparty/customcontrol/spreadsheetimporter/v1_3_0"]
}
```

Expand Down Expand Up @@ -349,7 +349,7 @@ builder:
configuration:
archiveName: uimodule
includeDependencies:
- ui5-cc-spreadsheetimporter-v1-2-2
- ui5-cc-spreadsheetimporter-v1-3-0
```

The metadata name is defined in the [`ui5.yaml`](https://github.com/spreadsheetimporter/ui5-cc-spreadsheetimporter/blob/9b61a778e5b0a5b66c15f5889334a6d684ae88de/packages/ui5-cc-spreadsheetimporter/ui5.yaml#L4) file of the component.
Expand All @@ -361,7 +361,7 @@ The metadata name is defined in the [`ui5.yaml`](https://github.com/spreadsheeti

When using decentralized deployment, deployment may fail with the following error:

`"Service name 'spreadsheetimporter_v1_2_2' and public setting 'true' in embedded manifest.json have to be equal to service name 'xxxxxxx' and public setting 'true' of root manifest.json"`
`"Service name 'spreadsheetimporter_v1_3_0' and public setting 'true' in embedded manifest.json have to be equal to service name 'xxxxxxx' and public setting 'true' of root manifest.json"`

SAP currently does not provide a fix for this.

Expand All @@ -386,7 +386,7 @@ builder:
afterTask: replaceVersion
```

This task will update the Spreadsheet Importer manifest with the app's service name at this path: `dist/thirdparty/customcontrol/spreadsheetimporter/v1_2_2/manifest.json`.
This task will update the Spreadsheet Importer manifest with the app's service name at this path: `dist/thirdparty/customcontrol/spreadsheetimporter/v1_3_0/manifest.json`.

##### Workaround 2

Expand Down
8 changes: 4 additions & 4 deletions docs/pages/Troubleshooting.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Alternatively, you can try selecting all the messages and copying them to a text
If you receive an error similar to the following:

```
ui5loader-dbg.js:1042 Uncaught (in promise) ModuleError: failed to load 'cc/spreadsheetimporter/v1_2_2/Component.js' from resources/cc/spreadsheetimporter/v1_2_2/Component.js: script load error
ui5loader-dbg.js:1042 Uncaught (in promise) ModuleError: failed to load 'cc/spreadsheetimporter/v1_3_0/Component.js' from resources/cc/spreadsheetimporter/v1_3_0/Component.js: script load error
```

Since the component is designed to always use a specific version, you must ensure that the correct version is used after an update.
Expand All @@ -59,16 +59,16 @@ See the configurations for this version below:
### manifest.json

!!! warning ""
⚠️ The `resourceRoots` path "./thirdparty/customcontrol/spreadsheetimporter/v1_2_2" changed from version 0.34.0 to lowercase. Please make sure to use the correct path.
⚠️ The `resourceRoots` path "./thirdparty/customcontrol/spreadsheetimporter/v1_3_0" changed from version 0.34.0 to lowercase. Please make sure to use the correct path.


```json
"componentUsages": {
"spreadsheetImporter": {
"name": "cc.spreadsheetimporter.v1_2_2"
"name": "cc.spreadsheetimporter.v1_3_0"
}
},
"resourceRoots": {
"cc.spreadsheetimporter.v1_2_2": "./thirdparty/customcontrol/spreadsheetimporter/v1_2_2"
"cc.spreadsheetimporter.v1_3_0": "./thirdparty/customcontrol/spreadsheetimporter/v1_3_0"
}
```
8 changes: 4 additions & 4 deletions docs/pages/Typescript.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,16 @@ You can consume the types from the `@sapui5/ts-types-esm` and the `ui5-cc-spread
Add the component usage and the resource roots to the manifest.json as described in the [Getting Started](GettingStarted.md) section.

!!! warning ""
⚠️ The `resourceRoots` path "./thirdparty/customcontrol/spreadsheetimporter/v1_2_2" changed from version 0.34.0 to lowercase. Please make sure to use the correct path.
⚠️ The `resourceRoots` path "./thirdparty/customcontrol/spreadsheetimporter/v1_3_0" changed from version 0.34.0 to lowercase. Please make sure to use the correct path.

```json
"componentUsages": {
"spreadsheetImporter": {
"name": "cc.spreadsheetimporter.v1_2_2"
"name": "cc.spreadsheetimporter.v1_3_0"
}
},
"resourceRoots": {
"cc.spreadsheetimporter.v1_2_2": "./thirdparty/customcontrol/spreadsheetimporter/v1_2_2"
"cc.spreadsheetimporter.v1_3_0": "./thirdparty/customcontrol/spreadsheetimporter/v1_3_0"
},
```

Expand All @@ -38,7 +38,7 @@ Add the component usage and the resource roots to the manifest.json as described
This is an example of how you could create the component and attach an event handler to the `checkBeforeRead` event with the types `Component` and `Component$CheckBeforeReadEventParameters` for the event parameters with an OData V4 Fiori Elements Application and UI5 Version 1.116.

```typescript
import Component, { Component$ChangeBeforeCreateEvent, Component$CheckBeforeReadEvent, Component$UploadButtonPressEvent } from "cc/spreadsheetimporter/v1_2_2/Component";
import Component, { Component$ChangeBeforeCreateEvent, Component$CheckBeforeReadEvent, Component$UploadButtonPressEvent } from "cc/spreadsheetimporter/v1_3_0/Component";
import BaseController from "sap/fe/core/BaseController";
import ExtensionAPI from "sap/fe/core/ExtensionAPI";

Expand Down
6 changes: 3 additions & 3 deletions examples/packages/anyupload/webapp/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
"sap.fe.templates": {}
},
"components": {
"cc.spreadsheetimporter.v1_2_2": {}
"cc.spreadsheetimporter.v1_3_0": {}
}
},
"contentDensities": {
Expand Down Expand Up @@ -110,11 +110,11 @@
},
"componentUsages": {
"spreadsheetImporter": {
"name": "cc.spreadsheetimporter.v1_2_2"
"name": "cc.spreadsheetimporter.v1_3_0"
}
},
"resourceRoots": {
"cc.spreadsheetimporter.v1_2_2": "./thirdparty/customcontrol/spreadsheetimporter/v1_2_2"
"cc.spreadsheetimporter.v1_3_0": "./thirdparty/customcontrol/spreadsheetimporter/v1_3_0"
},
"routing": {
"config": {},
Expand Down
4 changes: 2 additions & 2 deletions examples/packages/ordersv2fe/webapp/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -115,11 +115,11 @@
},
"componentUsages": {
"spreadsheetImporter": {
"name": "cc.spreadsheetimporter.v1_2_2"
"name": "cc.spreadsheetimporter.v1_3_0"
}
},
"resourceRoots": {
"cc.spreadsheetimporter.v1_2_2": "./thirdparty/customcontrol/spreadsheetimporter/v1_2_2"
"cc.spreadsheetimporter.v1_3_0": "./thirdparty/customcontrol/spreadsheetimporter/v1_3_0"
},
"routing": {
"config": {},
Expand Down
4 changes: 2 additions & 2 deletions examples/packages/ordersv2fenondraft/webapp/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,11 @@
},
"componentUsages": {
"spreadsheetImporter": {
"name": "cc.spreadsheetimporter.v1_2_2"
"name": "cc.spreadsheetimporter.v1_3_0"
}
},
"resourceRoots": {
"cc.spreadsheetimporter.v1_2_2": "./thirdparty/customcontrol/spreadsheetimporter/v1_2_2"
"cc.spreadsheetimporter.v1_3_0": "./thirdparty/customcontrol/spreadsheetimporter/v1_3_0"
},
"routing": {
"config": {},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"sap.ui.table": {}
},
"components": {
"cc.spreadsheetimporter.v1_2_2": {}
"cc.spreadsheetimporter.v1_3_0": {}
}
},
"contentDensities": {
Expand All @@ -79,14 +79,14 @@
},
"componentUsages": {
"spreadsheetImporter": {
"name": "cc.spreadsheetimporter.v1_2_2",
"name": "cc.spreadsheetimporter.v1_3_0",
"settings": {},
"componentData": {},
"lazy": false
}
},
"resourceRoots": {
"cc.spreadsheetimporter.v1_2_2": "./thirdparty/customcontrol/spreadsheetimporter/v1_2_2"
"cc.spreadsheetimporter.v1_3_0": "./thirdparty/customcontrol/spreadsheetimporter/v1_3_0"
},
"routing": {
"config": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"sap.ui.table": {}
},
"components": {
"cc.spreadsheetimporter.v1_2_2": {}
"cc.spreadsheetimporter.v1_3_0": {}
}
},
"contentDensities": {
Expand All @@ -79,11 +79,11 @@
},
"componentUsages": {
"spreadsheetImporter": {
"name": "cc.spreadsheetimporter.v1_2_2"
"name": "cc.spreadsheetimporter.v1_3_0"
}
},
"resourceRoots": {
"cc.spreadsheetimporter.v1_2_2": "./thirdparty/customcontrol/spreadsheetimporter/v1_2_2"
"cc.spreadsheetimporter.v1_3_0": "./thirdparty/customcontrol/spreadsheetimporter/v1_3_0"
},
"routing": {
"config": {
Expand Down
4 changes: 2 additions & 2 deletions examples/packages/ordersv4fe/webapp/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -110,11 +110,11 @@
},
"componentUsages": {
"spreadsheetImporter": {
"name": "cc.spreadsheetimporter.v1_2_2"
"name": "cc.spreadsheetimporter.v1_3_0"
}
},
"resourceRoots": {
"cc.spreadsheetimporter.v1_2_2": "./thirdparty/customcontrol/spreadsheetimporter/v1_2_2"
"cc.spreadsheetimporter.v1_3_0": "./thirdparty/customcontrol/spreadsheetimporter/v1_3_0"
},
"routing": {
"routes": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,12 @@ sap.ui.require(
errorMessage: "Can not select 'sap.m.Button'"
});
Then.waitFor({
controlType: "cc.spreadsheetimporter.v1_2_2.SpreadsheetDialog",
controlType: "cc.spreadsheetimporter.v1_3_0.SpreadsheetDialog",
check: function (dialog) {
return dialog[0].isOpen();
},
success: function (dialog) {
const util = Opa5.getWindow().cc.spreadsheetimporter.v1_2_2.Util;
const util = Opa5.getWindow().cc.spreadsheetimporter.v1_3_0.Util;
console.log("Util", util);
Opa5.getContext().util = util;
Opa5.getContext().component = dialog[0].getComponent();
Expand Down Expand Up @@ -71,7 +71,7 @@ sap.ui.require(

function testNormalizeNumberString(Then, decimalSeparator, input, expectedOutput) {
Then.waitFor({
controlType: "cc.spreadsheetimporter.v1_2_2.SpreadsheetDialog",
controlType: "cc.spreadsheetimporter.v1_3_0.SpreadsheetDialog",
success: function (dialog) {
Opa5.getContext().component.setDecimalSeparator(decimalSeparator);
// Call 'normalizeNumberString' method and check its output
Expand Down
Loading